[
https://issues.apache.org/jira/browse/FOP-3160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823590#comment-17823590
]
Simon Steiner edited comment on FOP-3160 at 3/5/24 1:07 PM:
------------------------------------------------------------
https://github.com/apache/xmlgraphics-fop/commit/d3ef77c7d66c49c84df92d5863dae49beaeca708
https://github.com/apache/xmlgraphics-fop/commit/3133a012c156e91876ad60383f9397d038f474a5
was (Author: ssteiner1):
https://github.com/apache/xmlgraphics-fop/commit/d3ef77c7d66c49c84df92d5863dae49beaeca708
> split packages within the FOP codebase
> --------------------------------------
>
> Key: FOP-3160
> URL: https://issues.apache.org/jira/browse/FOP-3160
> Project: FOP
> Issue Type: Improvement
> Reporter: Samael Bate
> Assignee: Simon Steiner
> Priority: Major
> Labels: jpms
>
> whilst taking a look at modularising the project (see: FOP-3159) I found that
> that package names are duplicated across the maven sub-modules.
> For example, both fop-core and fop-utils have _org.apache.fop.util.text._
>
> {code:java}
> [ERROR] the unnamed module reads package org.apache.fop.util from both
> org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
> [ERROR] the unnamed module reads package org.apache.fop.util.text from both
> org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
> [ERROR] the unnamed module reads package org.apache.fop.events from both
> org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
> [ERROR] the unnamed module reads package org.apache.fop.tools from both
> org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
> [ERROR] module commons.logging reads package org.apache.fop.events from both
> org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
> [ERROR] module commons.logging reads package org.apache.fop.tools from both
> org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
> [ERROR] module commons.logging reads package org.apache.fop.util from both
> org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
> [ERROR] module commons.logging reads package org.apache.fop.util.text from
> both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
> [ERROR] module batik.awt.util reads package org.apache.fop.events from both
> org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
> [ERROR] module batik.awt.util reads package org.apache.fop.tools from both
> org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
> [ERROR] module batik.awt.util reads package org.apache.fop.util from both
> org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
> [ERROR] module batik.awt.util reads package org.apache.fop.util.text from
> both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
> [ERROR] module qdox reads package org.apache.fop.events from both
> org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
> [ERROR] module qdox reads package org.apache.fop.tools from both
> org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
> [ERROR] module qdox reads package org.apache.fop.util from both
> org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
> [ERROR] module qdox reads package org.apache.fop.util.text from both
> org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
> [ERROR] module org.apache.commons.io reads package org.apache.fop.events from
> both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
> [ERROR] module org.apache.commons.io reads package org.apache.fop.tools from
> both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
> [ERROR] module org.apache.commons.io reads package org.apache.fop.util from
> both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
> [ERROR] module org.apache.commons.io reads package org.apache.fop.util.text
> from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
> [ERROR] module xmlgraphics.commons reads package org.apache.fop.events from
> both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
> [ERROR] module xmlgraphics.commons reads package org.apache.fop.tools from
> both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
> [ERROR] module xmlgraphics.commons reads package org.apache.fop.util from
> both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
> [ERROR] module xmlgraphics.commons reads package org.apache.fop.util.text
> from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
> [ERROR] module ant reads package org.apache.fop.events from both
> org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
> [ERROR] module ant reads package org.apache.fop.tools from both
> org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
> [ERROR] module ant reads package org.apache.fop.util from both
> org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
> [ERROR] module ant reads package org.apache.fop.util.text from both
> org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
> [ERROR] module servlet.api reads package org.apache.fop.events from both
> org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
> [ERROR] module servlet.api reads package org.apache.fop.tools from both
> org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
> [ERROR] module servlet.api reads package org.apache.fop.util from both
> org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
> [ERROR] module servlet.api reads package org.apache.fop.util.text from both
> org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
> {code}
> The project should be refactored a bit so that packages are not split across
> modules. This will be needed for JPMS
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
