Hi Vladimir,
PR requests are not our preferred way of accepting contributions. As
outlined at [1] we prefer a patch file attached to a JIRA ticket. What
we then usually do is put the contributors name in the commit message so
the details of the author are not lost.
If someone makes multiple contributions we notice that and invite them
to be on the contributors page at [2]
Thanks,
Chris
[1] https://xmlgraphics.apache.org/fop/dev/index.html#patches
[2] https://xmlgraphics.apache.org/fop/team.html#contribute-active
On 14/10/2026 02:52, Vladimir Sitnikov wrote:
Hi all,
On September 11 I asked on general@ about the authorship of two XML
Graphics Commons commits and got no reply. general@ has little
traffic, so I am asking here, where the committers are active. The
original message:
https://lists.apache.org/thread/t6s96g77jsls8x6pos5yk6rvfbm6vqxp
In short: my pull requests #32 (XGC-148, drop the commons-io
dependency) and #33 (skip dependency submission and SonarCloud for PR
checks) landed in main as 22e04a9b0a and cd7b9760d9. Each commit
matches its pull request line for line, but names a committer as the
author. GitHub builds the contributors list and profile activity from
the Author field, so these changes are not credited to me there.
Could a committer revert 22e04a9b0a and cd7b9760d9 and merge both pull
requests with the Squash button? A squash merge keeps the pull request
author as the commit author. The commits cannot be amended, because
.asf.yaml blocks force pushes to main.
For future pull requests, merging with the button, or applying the
change with “git am” or “git cherry-pick”, keeps the original author.
The committer is still recorded as the committer.
Thanks,
Vladimir Sitnikov
