In order to have a more consistent rubocop configuration across Foreman and Katello, I’d like to bring some cops that Katello has disabled in its rubocop configuration over to Foreman. These are cops that we’ve decided are a little bit too strict.
Currently they are disabled in the rubocop todo file in foreman meaning they are *not* being enforced but they could potentially be if someone removes them from the todo file. I’m hoping to get some feedback as to which ones people would like *not* to be disabled. I’ll collect the feedback and then open a PR based on it. For reference, here is our rubocop configuration in Katello: <https://github.com/Katello/katello/blob/master/.rubocop.yml> <https://github.com/Katello/katello/blob/master/.rubocop.yml> https://github.com/Katello/katello/blob/master/.rubocop.yml And here are the cops I’d like to disable: Style/LeadingCommentSpace <http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/LeadingCommentSpace> Style/IfUnlessModifier <http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/IfUnlessModifier> Style/RescueModifier <http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/RescueModifier> Style/AssignmentInCondition <http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Lint/AssignmentInCondition> Style/WhileUntilModifier <http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/WhileUntilModifier> Style/AlignParameters <http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/AlignParameters> Style/ParenthesesAroundCondition <http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/ParenthesesAroundCondition> Style/DotPosition <http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/DotPosition> Style/Lambda <http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/Lambda> Style/RedundantSelf <http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/RedundantSelf> Style/RedundantReturn <http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/RedundantReturn> Style/SpaceInsideHashLiteralBraces <http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/SpaceInsideHashLiteralBraces> Style/SingleLineBlockParams <http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/SingleLineBlockParams> Style/Next <http://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/Next> Style/FormatString <http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/FormatString> Style/GuardClause <http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/GuardClause> Style/StringLiterals <http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/StringLiterals> Style/WordArray <http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/WordArray> Rails/ScopeArgs <http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Rails/ScopeArgs> Style/EachWithObject <http://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/EachWithObject> Style/SymbolProc <http://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/SymbolProc> Let me know if there are any questions. Thanks. David -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
