On 23 August 2016 at 16:32, David Davis <[email protected]> wrote:
> I think there’s probably a happy medium between not using rubocop and > enabling all rubocop cops. > This. Speaking as an ex-sysadmin who tends to write functional but usually horrible code, Rubocop has been helpful to me in ensuring the consistency of what I write, and the complexity cops have encouraged me to rethink/refactor parts of my plugins. It definitely has a place. At one end, the big cops like complexity, length etc help me to produce good code. At the other end, the obvious low-fruit wins like whitespace consistency are fine. But in the middle is a grey area, and here I agree with Marek - it feels like nitpicking for the sake of nitpicking. Hash rockets feels like of of these nitpicks - it doesn't affect the quality of the code, and it's not a trivial change that's easy to agree on (as demonstrated). It's worth noting you can always add your own Rubocop yml file, it has a search path - so if you want to be more strict with yourself, you can :) $0.02 deposited :P Greg -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
