+1 for Daniel. IMHO most of the breakages that I saw were related to changes in the code that were not "officially declared" as API. Good examples are alias_method_chain for various methods.
On Friday, November 4, 2016 at 1:48:13 PM UTC+2, Daniel Lobato wrote: > > On 11/03, Greg Sutcliffe wrote: > > > > > > > You should file a bug against Foreman immediately if you see that a > > > plugin interface has been broken, so we can ensure the change isn't > > > released and a fix can be written. > > > > > > > Fair enough - in this case it's an interface that wasn't tested and a > user > > has found > > it subsequently (#17203 in set_hostgroup_defaults), so I think the > > not-releasing-it > > option is gone. I'll open an issue to write some tests for that > interface, > > though. > > > > More generally, does it make sense for someone to do an audit of the > most > > common > > places that plugins hook in, and make sure we have tests for them? > > The 'problem' is that the places plugins hook in are usually parts of > the app, e.g 'Host.foo', 'computeresource.bar'. The defined endpoints > for the plugin API are usually fine, but other methods that are equally > as important to the plugin could change behavior unexpectedly. > > Personally I think from core the important part is being aware of these > changes and communicating them promptly - helping to fix them when > possible too. > > > > > Cheers > > Greg > > > > -- > > You received this message because you are subscribed to the Google > Groups "foreman-dev" group. > > To unsubscribe from this group and stop receiving emails from it, send > an email to [email protected] <javascript:>. > > For more options, visit https://groups.google.com/d/optout. > > -- > Daniel Lobato Garcia > > @dLobatog > blog.daniellobato.me > daniellobato.me > > GPG: http://keys.gnupg.net/pks/lookup?op=get&search=0x7A92D6DD38D6DE30 > Keybase: https://keybase.io/elobato > -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
