On úterý 6. června 2017 9:54:12 CEST Tomas Strachota wrote: > On Mon, Jun 5, 2017 at 4:14 PM, Lukas Zapletal <[email protected]> wrote: > > On Mon, Jun 5, 2017 at 2:48 PM, Tomer Brisker <[email protected]> wrote: > >> My suggestion is that we replace the katello test currently running on > >> every PR with a test that installs the top 5 plugins together and runs > >> all of their tests. > > > > +1 +1 +1 > > > > Last week or two, Katello was red because of trivial regression in the > > testing framework, we did not block PRs at all, but eventually Daniel > > stepped up and fixed it. That sounds to me this works! If we can > > extend this to other plugins - big improvement for these. For > > discovery this would be huge improvement in overall stability. > > > > I agree that it should not make the jenkins load much worse, discovery > > and also other plugins has only dozens of tests, so the slowdown > > should not be significant I hope. We can stick with what Katello team > > does today - only test postgresql on particular ruby version (2.2 I > > think today). If we are able to run them all in one rake task, that > > would mean just one Rails boot as well. > > +1 for testing a set of most used plugins on postgresql and one ruby > version for each PR. Together with that we can still keep testing for > the full matrix once a week.
+1 to what was suggested except for the limit 5 :-) as long as plugins tests take less than 1 minute (usually it's within seconds), I think we can test more. plugins I'd like to see tested since they are not tiny and hence more prone to be broken by changes: remote execution discovery openscap -- Marek > > > What others say? Next steps would be: > > > > - nominate the plugins for this and vote them (or we can simple take > > most downloaded from our survey) > > - modify katello job to test all of them > > - rename katello job perhaps to avoid confusion? > > > > -- > > Later, > > > > Lukas @lzap Zapletal > > > > -- > > You received this message because you are subscribed to the Google Groups > > "foreman-dev" group. To unsubscribe from this group and stop receiving > > emails from it, send an email to > > [email protected]. For more options, visit > > https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
