As long as it won't override manually set release, that could work. I'm not 
sure if we distinguish between core and plugin in prprocessor but I suppose 
few "ifs" would do.

I'm OK with manual setting too since I open the redmine issue prior merge 
anyway to check the PR is linked to correct one and it implements the whole 
issue.

--
Marek

On středa 14. června 2017 22:05:28 CEST Sean O'Keeffe wrote:
> Is this something we could think about automating in similar way the PR is
> set by theforeman-bot ?
> 
> On Wed, 14 Jun 2017 at 20:50, Marek Hulán <[email protected]> wrote:
> > Hello
> > 
> > I'd like to kindly ask all Foreman committers to set the release version
> > in
> > the linked redmine issue after they merge the PR. In past, Dominic used to
> > do
> > it, unless it was set by the reviewer. Please correct me if I'm wrong but
> > I
> > think it's not going to happen any further.
> > 
> > I think it's very helpful to users and devs to easily find out, what
> > Foreman
> > version contains the fix, just by looking at redmine issue. Therefore I'd
> > like
> > to continue with this but I'd appreciate if we I'm not the only one who
> > set
> > it.
> > 
> > After PR is merged, the last existing version should be set to "Release"
> > field, atm it's 1.16.0. If you merged something that you believe should be
> > cherry-picked into last stable version, set that as a release, e.g.
> > "1.15.2".
> > Meaning of Release field is "the lowest Foreman version that contains the
> > fix".
> > 
> > I'll try to remind reviewers when I see it unset unless I get negative
> > reactions here. I'm going over all issues merged after 1.15 branching and
> > setting 1.16.0 where appropriate.
> > 
> > Thanks
> > 
> > --
> > Marek
> > 
> > --
> > You received this message because you are subscribed to the Google Groups
> > "foreman-dev" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> > email to [email protected].
> > For more options, visit https://groups.google.com/d/optout.


-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to