+1 from me as well, Chris has been working in the installer for a while now.
John Mitsch Red Hat Engineering (860)-967-7285 irc: jomitsch On Tue, Aug 1, 2017 at 3:04 PM, Eric D Helms <ericdhe...@gmail.com> wrote: > +1 from me, Chris has been very involved and adding value to both puppet > and installer itself. > > On Tue, Jul 25, 2017 at 6:54 PM, <chrob...@redhat.com> wrote: > >> Hi, >> >> Since my last request almost a year ago I have been making quite a lot of >> commits and they have gone from being pretty awful to alot better and >> through that I have been understanding Puppet and Ruby alot better thanks >> to people like Stephen Benjamin, Ekohl, and Justin. >> >> My commits started out as some basic Ruby but went on to more advanced >> Ruby and bigger Puppet commits. >> >> I have also been doing reviews of Puppet PRS mostly from Ekohl. >> >> Here are some of my PR's both in the Ruby and Puppet: >> >> https://github.com/Katello/katello-installer/pull/518 >> >> https://github.com/Katello/puppet-katello/pull/175 >> >> https://github.com/Katello/puppet-qpid/pull/51 >> >> https://github.com/Katello/puppet-katello/pull/168/files >> >> https://github.com/Katello/puppet-qpid/pull/65 >> >> https://github.com/Katello/puppet-qpid/pull/62 >> >> https://github.com/Katello/puppet-pulp/pull/189 >> >> https://github.com/Katello/puppet-katello/pull/162 >> >> https://github.com/Katello/katello-installer/pull/472 >> >> Here are some of the ones I have reviewed around puppet/Ruby recently: >> >> https://github.com/Katello/puppet-qpid/pull/60 >> >> https://github.com/Katello/puppet-katello/pull/190 >> >> https://github.com/Katello/puppet-katello/pull/198 >> >> Thanks, >> >> Chris Roberts >> >> -- >> You received this message because you are subscribed to the Google Groups >> "foreman-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to foreman-dev+unsubscr...@googlegroups.com. >> For more options, visit https://groups.google.com/d/optout. >> > > > > -- > Eric D. Helms > Red Hat Engineering > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.