Tests are green, let's merge this, big thanks for help. LZ
On Thu, Sep 21, 2017 at 12:13 PM, Ivan Necas <[email protected]> wrote: > That was exacly the reason I was sending the pr Marek referenced: will get > to fixing the broken tests later today. Reviews welcome > > -- Ivan > > On Thu, 21 Sep 2017 at 10:19, Marek Hulán <[email protected]> wrote: >> >> On čtvrtek 21. září 2017 9:46:59 CEST Lukas Zapletal wrote: >> > Hello, >> > >> > we are getting errors in discovery develop due to Rails 5 update: >> > >> > ActiveRecord::SubclassNotFound: Invalid single-table inheritance type: >> > Host::Discovered is not a subclass of Host::Managed >> > >> > >> > http://ci.theforeman.org/job/test_plugin_matrix/3760/database=mysql,ruby=2.4 >> > >> > ,slave=fast/testReport/junit/(root)/DiscoveredHostsControllerTest/test_updat >> > e_inheritance/ >> > >> > If anyone have ideas, please help me to resolve this. There are couple >> > of PRs pending review but I need to get tests green before. We do some >> > weird magic in Host and some STI changes in Rails5 regressed. I have >> > no idea. >> >> Have you tried Ivan's PR? [1] >> >> [1] https://github.com/theforeman/foreman/pull/4864 >> >> -- >> Marek >> >> -- >> You received this message because you are subscribed to the Google Groups >> "foreman-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> For more options, visit https://groups.google.com/d/optout. -- Later, Lukas @lzap Zapletal -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
