Hello,

The Thoughtbot team have decided to rename the factory_girl gem, which we
depend on for tests, to factory_bot [1]. This led to our CI breaking due to
the name change. For now, we have pinned factory_girl to the last working
version to unblock CI, but we should prepare to change to the new name.

This requires, basically, changing every occurrence of `FactoryGirl` to
`FactoryBot`, and every `factory_girl` to `factory_bot`. Other then the
name change, no other changes were made to the API.

Marek has opened a PR[2] for fixing this in foreman-core, however once this
is merged it will break tests for all plugins depending on the core
factory_girl. To prevent prolonged breakage, all plugin maintainers should
work to prepare a PR making the above mentioned change, so that it can be
merged once core PR is merged.

To give you some time to fix this and prevent breakage, the core PR will be
merged one week from today, on November 1st. Please make sure you are
prepared to correctly handle this change in your plugin. If needed, feel
free to reach out to me, Marek, or any of the other core maintainers.

​[1] https://github.com/thoughtbot/factory_bot/issues/921​
​[2] https://github.com/theforeman/foreman/pull/4935​

-- 
Have a nice day,
Tomer Brisker
Red Hat Engineering

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to