On 12/06, Ohad Levy wrote: > On Wed, Dec 6, 2017 at 9:10 PM, Walden Raines <[email protected]> wrote: > > > > Oh yeah, especially notifications. Why can't they just update when the > > page updates? > > > > I think it would be good to move the notifications to a websocket approach > > instead of polling. I know, I know, PRs welcome :) > > > > We can consider using SSE for sending notifications too, but I'm uncertain > how it would play with passenger. a more reliable approach would probably > be to start using redis + websockets additional service proxied by apache > (and webpack in development)
I tried to make the Job Invocations donut chart work with ActionCable (so yeah, WebSockets): https://github.com/dlobatog/foreman/tree/actioncable , needs foreman_remote_execution to work Unfortunately.. https://www.phusionpassenger.com/library/config/apache/action_cable_integration/ If anyone wants to spend time changing our stack to be Passenger standalone behind an Apache proxy, I'd welcome the change but I am not sure whether that's worth the effort/possible bugs/etc.. Having said that, notification updates (they're cached) are only a hassle because they're logged. At least I don't notice any slowness or anything, especially since they're cached. > > Ohad > > > > > On Wed, Dec 6, 2017 at 1:23 PM, Ohad Levy <[email protected]> wrote: > > > >> > >> > >> On Dec 6, 2017 12:19 PM, "Ivan Necas" <[email protected]> wrote: > >> > >> The only concern, as the users are used to the auto-refresh, once we turn > >> that off, they can start thinking the thing got stuck. > >> > >> > >> In that case let's keep updating the talk progress without replacing the > >> entire tab? > >> > >> > >> -- Ivan > >> > >> On Wed, 6 Dec 2017 at 17:50, Ohad Levy <[email protected]> wrote: > >> > >>> On Wed, Dec 6, 2017 at 6:48 PM, Andrew Kofink <[email protected]> > >>> wrote: > >>> > >>>> As part of this I would love to see *all* auto reloads default to off > >>>>> > >>>> > >>> +1 - PR are welcomes ;) > >>> > >>> > >>>> Oh yeah, especially notifications. Why can't they just update when the > >>>> page updates? > >>>> > >>>> On Wed, Dec 6, 2017 at 11:27 AM, Walden Raines <[email protected]> > >>>> wrote: > >>>> > >>>>> > I think the refresh should still be off by default. > >>>>> > >>>>> As part of this I would love to see *all* auto reloads default to > >>>>> off. The dashboard, for example, constantly reloading by default is > >>>>> annoying to me. > >>>>> > >>>>> Cheers, > >>>>> Walden > >>>>> > >>>>> On Wed, Dec 6, 2017 at 11:16 AM, Andrew Kofink <[email protected]> > >>>>> wrote: > >>>>> > >>>>>> Hello, > >>>>>> > >>>>>> We have the option of toggling auto-refresh on individual tasks, but > >>>>>> I often find myself at the foreman_tasks#tasks page intermittently > >>>>>> clicking > >>>>>> the search button to monitor the state of automated tasks (in my case, > >>>>>> usually bats content/proxy tests). I'm proposing a button or an option > >>>>>> under the search drop down button to enable/disable auto refresh. I > >>>>>> think > >>>>>> the refresh should still be off by default. > >>>>>> > >>>>>> Any comments? > >>>>>> > >>>>>> - Andrew > >>>>>> > >>>>>> -- > >>>>>> Andrew Kofink > >>>>>> [email protected] > >>>>>> IRC: akofink > >>>>>> Software Engineer > >>>>>> Red Hat Satellite > >>>>>> > >>>>>> -- > >>>>>> You received this message because you are subscribed to the Google > >>>>>> Groups "foreman-dev" group. > >>>>>> To unsubscribe from this group and stop receiving emails from it, > >>>>>> send an email to [email protected]. > >>>>>> For more options, visit https://groups.google.com/d/optout. > >>>>>> > >>>>> > >>>>> -- > >>>>> You received this message because you are subscribed to the Google > >>>>> Groups "foreman-dev" group. > >>>>> To unsubscribe from this group and stop receiving emails from it, send > >>>>> an email to [email protected]. > >>>>> For more options, visit https://groups.google.com/d/optout. > >>>>> > >>>> > >>>> > >>>> > >>>> -- > >>>> Andrew Kofink > >>>> [email protected] > >>>> IRC: akofink > >>>> Software Engineer > >>>> Red Hat Satellite > >>>> > >>>> -- > >>>> You received this message because you are subscribed to the Google > >>>> Groups "foreman-dev" group. > >>>> To unsubscribe from this group and stop receiving emails from it, send > >>>> an email to [email protected]. > >>>> For more options, visit https://groups.google.com/d/optout. > >>>> > >>> -- > >>> You received this message because you are subscribed to the Google > >>> Groups "foreman-dev" group. > >>> To unsubscribe from this group and stop receiving emails from it, send > >>> an email to [email protected]. > >>> For more options, visit https://groups.google.com/d/optout. > >>> > >> -- > >> You received this message because you are subscribed to the Google Groups > >> "foreman-dev" group. > >> To unsubscribe from this group and stop receiving emails from it, send an > >> email to [email protected]. > >> For more options, visit https://groups.google.com/d/optout. > >> > >> > >> -- > >> You received this message because you are subscribed to the Google Groups > >> "foreman-dev" group. > >> To unsubscribe from this group and stop receiving emails from it, send an > >> email to [email protected]. > >> For more options, visit https://groups.google.com/d/optout. > >> > > > > -- > > You received this message because you are subscribed to the Google Groups > > "foreman-dev" group. > > To unsubscribe from this group and stop receiving emails from it, send an > > email to [email protected]. > > For more options, visit https://groups.google.com/d/optout. > > > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. -- Daniel Lobato Garcia @dLobatog blog.daniellobato.me daniellobato.me GPG: http://keys.gnupg.net/pks/lookup?op=get&search=0x7A92D6DD38D6DE30 Keybase: https://keybase.io/elobato -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
signature.asc
Description: PGP signature
