Could you please comment on the pull request as well ( https://github.com/theforeman/foreman/pull/3980)? That way reviewers will know that it has already been tested and fixes the issue.
On Tue, Nov 1, 2016 at 12:54 PM, Erez Zarum <[email protected]> wrote: > Ok, patch applied, works :) > > Thank you very much! > > > On Tuesday, November 1, 2016 at 12:48:59 PM UTC+2, Erez Zarum wrote: > >> Hey Tomer, >> I was under the impression i am the only one having it (haven't tested on >> a fresh install), will track it. >> >> Thanks, >> Erez >> >> On Tuesday, November 1, 2016 at 10:16:18 AM UTC+2, Tomer Brisker wrote: >> >>> Hi Erez, >>> >>> Thank you for the detailed report! >>> I have opened http://projects.theforeman.org/issues/17152 to track it >>> and will hopefully have a fix ready for testing later today. >>> >>> On Mon, Oct 31, 2016 at 5:59 PM, Erez Zarum <[email protected]> wrote: >>> >>>> Since the upgrade to 1.13.1 (from 1.12) when i go into the Smart proxy >>>> tab (dashboard) and choose the "Puppet" tab, I get an exception: "*Oops, >>>> we're sorry but something went wrong *undefined method `latest_events' >>>> for nil:NilClass" >>>> >>>> Full trace: >>>> *NoMethodError* >>>> *undefined method `latest_events' for nil:NilClass* >>>> /usr/share/foreman/app/views/dashboard/_reports_widget.html.erb:4:in ` >>>> _acaa7ba2769e19ed205bbe4662a97c5a' >>>> /opt/rh/sclo-ror42/root/usr/share/gems/gems/actionview-4.2. >>>> 5.1/lib/action_view/template.rb:145:in `block in render' >>>> /opt/rh/sclo-ror42/root/usr/share/gems/gems/activesupport-4.2.5.1/lib/ >>>> active_support/notifications.rb:166:in `instrument' >>>> /opt/rh/sclo-ror42/root/usr/share/gems/gems/actionview-4.2. >>>> 5.1/lib/action_view/template.rb:333:in `instrument' >>>> /opt/rh/sclo-ror42/root/usr/share/gems/gems/actionview-4.2. >>>> 5.1/lib/action_view/template.rb:143:in `render' >>>> /opt/theforeman/tfm/root/usr/share/gems/gems/deface-1.0.2/lib/deface/ >>>> action_view_extensions.rb:41:in `render' >>>> /opt/rh/sclo-ror42/root/usr/share/gems/gems/actionview-4.2. >>>> 5.1/lib/action_view/renderer/partial_renderer.rb:339:in `render_partial >>>> ' >>>> /opt/rh/sclo-ror42/root/usr/share/gems/gems/actionview-4.2. >>>> 5.1/lib/action_view/renderer/partial_renderer.rb:310:in `block in >>>> render' >>>> /opt/rh/sclo-ror42/root/usr/share/gems/gems/actionview-4.2.5.1/lib/ >>>> action_view/renderer/abstract_renderer.rb:39:in `block in instrument' >>>> /opt/rh/sclo-ror42/root/usr/share/gems/gems/activesupport-4. >>>> 2.5.1/lib/active_support/notifications.rb:164:in `block in instrument' >>>> /opt/rh/sclo-ror42/root/usr/share/gems/gems/activesupport-4. >>>> 2.5.1/lib/active_support/notifications/instrumenter.rb:20:in >>>> `instrument' >>>> /opt/rh/sclo-ror42/root/usr/share/gems/gems/activesupport-4.2.5.1/lib/ >>>> active_support/notifications.rb:164:in `instrument' >>>> /opt/rh/sclo-ror42/root/usr/share/gems/gems/actionview-4.2. >>>> 5.1/lib/action_view/renderer/abstract_renderer.rb:39:in `instrument' >>>> /opt/rh/sclo-ror42/root/usr/share/gems/gems/actionview-4.2. >>>> 5.1/lib/action_view/renderer/partial_renderer.rb:309:in `render' >>>> /opt/rh/sclo-ror42/root/usr/share/gems/gems/actionview-4.2.5.1/lib/ >>>> action_view/renderer/renderer.rb:51:in `render_partial' >>>> /opt/rh/sclo-ror42/root/usr/share/gems/gems/actionview-4.2. >>>> 5.1/lib/action_view/renderer/renderer.rb:25:in `render' >>>> /opt/rh/sclo-ror42/root/usr/share/gems/gems/actionview-4.2. >>>> 5.1/lib/action_view/helpers/rendering_helper.rb:32:in `render' >>>> /usr/share/foreman/app/views/smart_proxies/plugins/_puppet_dashboard. >>>> html.erb:2:in `_4c40b743d7cef76300e063bcefffa3b8' >>>> /opt/rh/sclo-ror42/root/usr/share/gems/gems/actionview-4.2. >>>> 5.1/lib/action_view/template.rb:145:in `block in render' >>>> /opt/rh/sclo-ror42/root/usr/share/gems/gems/activesupport-4. >>>> 2.5.1/lib/active_support/notifications.rb:166:in `instrument' >>>> /opt/rh/sclo-ror42/root/usr/share/gems/gems/actionview-4.2.5.1/lib/ >>>> action_view/template.rb:333:in `instrument' >>>> /opt/rh/sclo-ror42/root/usr/share/gems/gems/actionview-4.2. >>>> 5.1/lib/action_view/template.rb:143:in `render' >>>> /opt/theforeman/tfm/root/usr/share/gems/gems/deface-1.0.2/li >>>> b/deface/action_view_extensions.rb:41:in `render' >>>> /opt/rh/sclo-ror42/root/usr/share/gems/gems/actionview-4.2.5.1/lib/ >>>> action_view/renderer/partial_renderer.rb:339:in `render_partial' >>>> /opt/rh/sclo-ror42/root/usr/share/gems/gems/actionview-4.2. >>>> 5.1/lib/action_view/renderer/partial_renderer.rb:310:in `block in >>>> render' >>>> /opt/rh/sclo-ror42/root/usr/share/gems/gems/actionview-4.2. >>>> 5.1/lib/action_view/renderer/abstract_renderer.rb:39:in `block in >>>> instrument' >>>> /opt/rh/sclo-ror42/root/usr/share/gems/gems/activesupport-4.2.5.1/lib/ >>>> active_support/notifications.rb:164:in `block in instrument' >>>> /opt/rh/sclo-ror42/root/usr/share/gems/gems/activesupport-4. >>>> 2.5.1/lib/active_support/notifications/instrumenter.rb:20:in ` >>>> instrument' >>>> /opt/rh/sclo-ror42/root/usr/share/gems/gems/activesupport-4. >>>> 2.5.1/lib/active_support/notifications.rb:164:in `instrument' >>>> /opt/rh/sclo-ror42/root/usr/share/gems/gems/actionview-4.2.5.1/lib/ >>>> action_view/renderer/abstract_renderer.rb:39:in `instrument' >>>> /opt/rh/sclo-ror42/root/usr/share/gems/gems/actionview-4.2. >>>> 5.1/lib/action_view/renderer/partial_renderer.rb:309:in `render' >>>> /opt/rh/sclo-ror42/root/usr/share/gems/gems/actionview-4.2. >>>> 5.1/lib/action_view/renderer/renderer.rb:51:in `render_partial' >>>> /opt/rh/sclo-ror42/root/usr/share/gems/gems/actionview-4.2.5.1/lib/ >>>> action_view/renderer/renderer.rb:25:in `render' >>>> /opt/rh/sclo-ror42/root/usr/share/gems/gems/actionview-4.2. >>>> 5.1/lib/action_view/rendering.rb:100:in `_render_template' >>>> /opt/rh/sclo-ror42/root/usr/share/gems/gems/actionpack-4.2. >>>> 5.1/lib/action_controller/metal/streaming.rb:217:in `_render_template' >>>> /opt/rh/sclo-ror42/root/usr/share/gems/gems/actionview-4.2.5.1/lib/ >>>> action_view/rendering.rb:83:in `render_to_body' >>>> /opt/rh/sclo-ror42/root/usr/share/gems/gems/actionpack-4.2. >>>> 5.1/lib/action_controller/metal/rendering.rb:32:in `render_to_body' >>>> /opt/rh/sclo-ror42/root/usr/share/gems/gems/actionpack-4.2. >>>> 5.1/lib/action_controller/metal/renderers.rb:37:in `render_to_body' >>>> /opt/rh/sclo-ror42/root/usr/share/gems/gems/actionpack-4.2.5.1/lib/ >>>> abstract_controller/rendering.rb:25:in `render' >>>> /opt/rh/sclo-ror42/root/usr/share/gems/gems/actionpack-4.2. >>>> 5.1/lib/action_controller/metal/rendering.rb:16:in `render' >>>> /opt/rh/sclo-ror42/root/usr/share/gems/gems/actionpack-4.2. >>>> 5.1/lib/action_controller/metal/instrumentation.rb:44:in `block (2 >>>> levels) in render' >>>> /opt/rh/sclo-ror42/root/usr/share/gems/gems/activesupport-4.2.5.1/lib/ >>>> active_support/core_ext/benchmark.rb:12:in `block in ms' >>>> /opt/rh/rh-ruby22/root/usr/share/ruby/benchmark.rb:303:in `realtime' >>>> /opt/rh/sclo-ror42/root/usr/share/gems/gems/activesupport-4. >>>> 2.5.1/lib/active_support/core_ext/benchmark.rb:12:in `ms' >>>> /opt/rh/sclo-ror42/root/usr/share/gems/gems/actionpack-4.2.5.1/lib/ >>>> action_controller/metal/instrumentation.rb:44:in `block in render' >>>> /opt/rh/sclo-ror42/root/usr/share/gems/gems/actionpack-4.2. >>>> 5.1/lib/action_controller/metal/instrumentation.rb:87:in ` >>>> cleanup_view_runtime' >>>> <span style="font-family:"Open Sans",Helveti >>>> >>> -- > You received this message because you are subscribed to the Google Groups > "Foreman users" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at https://groups.google.com/group/foreman-users. > For more options, visit https://groups.google.com/d/optout. > -- Have a nice day, Tomer Brisker Red Hat Engineering -- You received this message because you are subscribed to the Google Groups "Foreman users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/foreman-users. For more options, visit https://groups.google.com/d/optout.
