Your message dated Wed, 27 Aug 2014 09:37:38 +0000
with message-id <[email protected]>
and subject line Bug#754816: fixed in libewf 20140608-2
has caused the Debian Bug report #754816,
regarding libewf: FTBFS on hurd-386
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
754816: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=754816
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: libewf
Version: 20130416-3
Severity: important
Tags: patch
User: [email protected]
Usertags: hurd

Hello,

libewf fails to build from source due to usage of PATH_MAX, which is not
defined on GNU/Hurd. The attached patch fixes usage of PATH_MAX as
second argument to getcwd() by using calls to getcwd (NULL, 0) instead.
Supporting (NULL, 0) as arguments is an extension to POSIX.1-2001 for
libc4, libc5 and glibc, so most modern systems have it. In order to
simplify the patch, only this version is implemented.

In case there is a need for a dual code path this can be fixed too, at
the cost of additional #ifdef's in the code and a configure.ac check for
the getcwd (NULL, 0) functionality.

libewf is flagged as out-of-date since a long time by now for Hurd and
with the PATH_MAX fix of libbfio in bug #754792 and this patch it will
be up-to-date again.

Thanks! 

Index: libewf-20130416/libcpath/libcpath_path.c
===================================================================
--- libewf-20130416.orig/libcpath/libcpath_path.c
+++ libewf-20130416/libcpath/libcpath_path.c
@@ -356,9 +356,6 @@ int libcpath_path_get_current_working_di
 	}
 #if defined( WINAPI )
 	*current_working_directory_size = (size_t) _MAX_PATH;
-#else
-	*current_working_directory_size = (size_t) PATH_MAX;
-#endif
 	*current_working_directory = libcstring_narrow_string_allocate(
 	                              *current_working_directory_size );
 
@@ -387,7 +384,6 @@ int libcpath_path_get_current_working_di
 
 		goto on_error;
 	}
-#if defined( WINAPI )
 	if( _getcwd(
 	     *current_working_directory,
 	     *current_working_directory_size ) == NULL )
@@ -403,9 +399,10 @@ int libcpath_path_get_current_working_di
 		goto on_error;
 	}
 #else
-	if( getcwd(
-	     *current_working_directory,
-	     *current_working_directory_size ) == NULL )
+	*current_working_directory = getcwd(
+		 NULL,
+		 0);
+	if( *current_working_directory == NULL )
 	{
 		libcerror_system_set_error(
 		 error,
@@ -417,6 +414,8 @@ int libcpath_path_get_current_working_di
 
 		goto on_error;
 	}
+	*current_working_directory_size = 1 + libcstring_narrow_string_length(
+	                                             *current_working_directory );
 #endif
 	return( 1 );
 
@@ -3108,24 +3107,11 @@ int libcpath_path_get_current_working_di
 #if defined( WINAPI )
 	*current_working_directory_size = (size_t) _MAX_PATH;
 #else
-	narrow_current_working_directory = libcstring_narrow_string_allocate(
-	                                    PATH_MAX );
-
+	narrow_current_working_directory = getcwd(
+		 NULL,
+		 0);
 	if( narrow_current_working_directory == NULL )
 	{
-		libcerror_error_set(
-		 error,
-		 LIBCERROR_ERROR_DOMAIN_MEMORY,
-		 LIBCERROR_MEMORY_ERROR_INSUFFICIENT,
-		 "%s: unable to create narrow current working directory.",
-		 function );
-
-		goto on_error;
-	}
-	if( getcwd(
-	     narrow_current_working_directory,
-	     PATH_MAX ) == NULL )
-	{
 		libcerror_system_set_error(
 		 error,
 		 LIBCERROR_ERROR_DOMAIN_RUNTIME,

--- End Message ---
--- Begin Message ---
Source: libewf
Source-Version: 20140608-2

We believe that the bug you reported is fixed in the latest version of
libewf, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Pierre Chifflier <[email protected]> (supplier of updated libewf package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Wed, 27 Aug 2014 09:22:45 +0200
Source: libewf
Binary: libewf2 libewf-dbg libewf-dev ewf-tools
Architecture: source amd64
Version: 20140608-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Forensics <[email protected]>
Changed-By: Pierre Chifflier <[email protected]>
Description:
 ewf-tools  - collection of tools for reading and writing EWF files
 libewf-dbg - library with support for Expert Witness Compression Format (debug
 libewf-dev - support for Expert Witness Compression format (development)
 libewf2    - library with support for Expert Witness Compression Format
Closes: 754816
Changes:
 libewf (20140608-2) unstable; urgency=medium
 .
   * Fix FTBFS on hurd-386 (Closes: #754816)
     Thanks to Svante Signell for the patch.
Checksums-Sha1:
 3201645ea51bde900eaffd17dad7c74f24993e69 1880 libewf_20140608-2.dsc
 9841828f3c759f6d3d0f8c0bd74f4b51ea72336b 11276 libewf_20140608-2.debian.tar.xz
 407f176c44a9e8692bb63f21aede6c35c4eebaad 517520 libewf2_20140608-2_amd64.deb
 88b8c55c0ea009d3c3faaae9c2dbca50f2f4a966 2585064 
libewf-dbg_20140608-2_amd64.deb
 4942f2c451e92bce3927a937c00c44eb4a2d80e5 534784 libewf-dev_20140608-2_amd64.deb
 136e42a70d5fa9bdd8a746f306319c4b0160f489 650130 ewf-tools_20140608-2_amd64.deb
Checksums-Sha256:
 9dda45794bce27127cd371f666123167edc9651e184e07721be0b44005ff6bd0 1880 
libewf_20140608-2.dsc
 ad4102d0292bfb4945daafa7df12c527b69f70e9b2a3188a3f709d51915dbca6 11276 
libewf_20140608-2.debian.tar.xz
 1c01cb91325f257be41c553bc70dfc0268e91017032dce7b02716bf83c85764d 517520 
libewf2_20140608-2_amd64.deb
 9589986d11012799a550ffb86269919777b5e2821899bf536270938332c4235d 2585064 
libewf-dbg_20140608-2_amd64.deb
 d8fa0b8a29c455a6728a91fcb4b492de5935628b76bd07a2b6b74ee5b1b5d3d1 534784 
libewf-dev_20140608-2_amd64.deb
 b2f37b9bba06f90eb214c37bb368a86eda36c03ffff37368442e898fe863926d 650130 
ewf-tools_20140608-2_amd64.deb
Files:
 e80df05b2fdd99ae2a5b2e1584e7ffb0 517520 libs optional 
libewf2_20140608-2_amd64.deb
 e3e1fc913f53c0ae81335e9b181a3c68 2585064 debug extra 
libewf-dbg_20140608-2_amd64.deb
 04424bab995858bad3b732658607a5c8 534784 libdevel optional 
libewf-dev_20140608-2_amd64.deb
 ffa329006f1e996e92d498e3a815f6f1 650130 admin optional 
ewf-tools_20140608-2_amd64.deb
 59adf59fad5f7ff36a081bbac9342c73 1880 libs optional libewf_20140608-2.dsc
 0ec4381824769ddfb09493d6a5db2cca 11276 libs optional 
libewf_20140608-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJT/aTGAAoJEFqCeQfe0MQYQSkH+wZ/mvtlklKybPs7D3e1ANS+
0X9kzGJSKD1m0QeuzfyZQZv72e4IEcYCmFOwd1MpImU4CY8ottRpFpwypGR/bTSf
vDkzwu+k5whhSP90/vgClGYiPiNqMhx1FcpeCHXP8cqkYErcPSaHCqeVQMYfMAE2
s52LPJxXFslX3Neet+9SWnj5xw5mQ54ojYkDX4S2bM86Lg9Jls0rXizQm2M+TV0p
ZkzOiyiRSKuP33zuGcHp5VknQa3nx5L304K4CUcy1+SRyHCSr6UYYj8wsMTIuywA
dF8xpNYWbSqXgaQvYV3LHAUEcl7Uqq0qtUEhLxf8iHrGZWlwxqdy6AcvM2VJeI4=
=167S
-----END PGP SIGNATURE-----

--- End Message ---
_______________________________________________
forensics-devel mailing list
[email protected]
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/forensics-devel

Reply via email to