Your message dated Thu, 28 Aug 2014 07:19:21 +0000
with message-id <[email protected]>
and subject line Bug#754818: fixed in libpff 20120802-2
has caused the Debian Bug report #754818,
regarding libpff: FTBFS on hurd-386
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
754818: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=754818
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: libpff
Version: 20120802-1
Severity: important
Tags: patch
User: [email protected]
Usertags: hurd
Hello,
libpff fails to build from source due to usage of PATH_MAX, which is not
defined on GNU/Hurd. The attached patch fixes usage of PATH_MAX as
second argument to getcwd() by using calls to getcwd (NULL, 0) instead.
Supporting (NULL, 0) as arguments is an extension to POSIX.1-2001 for
libc4, libc5 and glibc, so most modern systems have it. In order to
simplify the patch, only this version is implemented.
In case there is a need for a dual code path this can be fixed too, at
the cost of additional #ifdef's in the code and a configure.ac check for
the getcwd (NULL, 0) functionality.
libpff does not build on Hurd but with the PATH_MAX fix of libbfio in
bug #754792 and this patch it will.
Note: This patch is almost identical to the one in libewf: #754816 and
parts of libbfio: #754792
Thanks!
Index: libpff-20120802/libcpath/libcpath_path.c
===================================================================
--- libpff-20120802.orig/libcpath/libcpath_path.c
+++ libpff-20120802/libcpath/libcpath_path.c
@@ -342,12 +342,6 @@ int libcpath_path_get_current_working_di
}
#if defined( WINAPI )
*current_working_directory_size = (size_t) _MAX_PATH;
-
-#else
- *current_working_directory_size = (size_t) PATH_MAX;
-
-#endif
-
*current_working_directory = libcstring_narrow_string_allocate(
*current_working_directory_size );
@@ -362,7 +356,6 @@ int libcpath_path_get_current_working_di
goto on_error;
}
-#if defined( WINAPI )
if( _getcwd(
*current_working_directory,
*current_working_directory_size ) == NULL )
@@ -378,9 +371,10 @@ int libcpath_path_get_current_working_di
goto on_error;
}
#else
- if( getcwd(
- *current_working_directory,
- *current_working_directory_size ) == NULL )
+ *current_working_directory = getcwd(
+ NULL,
+ 0);
+ if( *current_working_directory == NULL )
{
libcerror_system_set_error(
error,
@@ -392,6 +386,8 @@ int libcpath_path_get_current_working_di
goto on_error;
}
+ *current_working_directory_size = 1 + libcstring_narrow_string_length(
+ *current_working_directory );
#endif
return( 1 );
@@ -3048,24 +3044,11 @@ int libcpath_path_get_current_working_di
*current_working_directory_size = (size_t) _MAX_PATH;
#else
- narrow_current_working_directory = libcstring_narrow_string_allocate(
- PATH_MAX );
-
+ narrow_current_working_directory = getcwd(
+ NULL,
+ 0);
if( narrow_current_working_directory == NULL )
{
- libcerror_error_set(
- error,
- LIBCERROR_ERROR_DOMAIN_MEMORY,
- LIBCERROR_MEMORY_ERROR_INSUFFICIENT,
- "%s: unable to create narrow current working directory.",
- function );
-
- goto on_error;
- }
- if( getcwd(
- narrow_current_working_directory,
- PATH_MAX ) == NULL )
- {
libcerror_system_set_error(
error,
LIBCERROR_ERROR_DOMAIN_RUNTIME,
--- End Message ---
--- Begin Message ---
Source: libpff
Source-Version: 20120802-2
We believe that the bug you reported is fixed in the latest version of
libpff, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Pierre Chifflier <[email protected]> (supplier of updated libpff package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Thu, 28 Aug 2014 08:59:52 +0200
Source: libpff
Binary: libpff1 libpff-dbg libpff-dev pff-tools
Architecture: source amd64
Version: 20120802-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Forensics <[email protected]>
Changed-By: Pierre Chifflier <[email protected]>
Description:
libpff-dbg - library to access various ms outlook files formats (debug).
libpff-dev - library to access various ms outlook files formats (development).
libpff1 - library to access various ms outlook files formats.
pff-tools - library to access various ms outlook files formats.
Closes: 735642 754818
Changes:
libpff (20120802-2) unstable; urgency=medium
.
* Use dh-autoreconf instead of autotools-dev (Closes: #735642)
* Remove deprecated field DM-Upload-Allowed
* Switch to Debian source format 3.0 (quilt)
* Fix FTBFS on hurd-386 (Closes: #754818)
Thanks to Svante Signell for the patch.
Checksums-Sha1:
f731b14e0348878fe432f27bdd01caf87a88e4ab 1777 libpff_20120802-2.dsc
8a8935cda1dd0a3aa195c4c567241dffbc4758a5 8128 libpff_20120802-2.debian.tar.xz
25e0b3c0015beefbb5ade67a6b876dd6f5df889a 429522 libpff1_20120802-2_amd64.deb
14537efe203d58de8e4d86606bdb97e7def354c7 829780 libpff-dbg_20120802-2_amd64.deb
a202129cf7359925c590345b3c7b48d02548342c 449192 libpff-dev_20120802-2_amd64.deb
96e192bcdfd894b142b06910eb44a97ea5c4cd0f 355080 pff-tools_20120802-2_amd64.deb
Checksums-Sha256:
3b022b01dc543a42718b9557ae3de99c3cbf58fd1b6a1a4f2097a1d60ef0ecba 1777
libpff_20120802-2.dsc
de4b95d8cd26a0013cb9ac2e6112c84953eb76fb7a98ca9656b125bae734663a 8128
libpff_20120802-2.debian.tar.xz
0d3b9ecb24a90660de7761c184247032a4188bb56fdf222b216d9b72bc948f5d 429522
libpff1_20120802-2_amd64.deb
f9a531d746590f2d1a487d9f07b8771c497711fbf11bda4687a892f431cc015f 829780
libpff-dbg_20120802-2_amd64.deb
ba582432df3c0b3747623052694214f9a3cf71506dfd2b67a23a3399d3c007f4 449192
libpff-dev_20120802-2_amd64.deb
bfc0882b396605e4cdd0d8c9705d9a73cb6185c8a2a94b6b8210b95ac44e9d6b 355080
pff-tools_20120802-2_amd64.deb
Files:
bd55626a81911e1749691ab8a1e14efb 429522 libs optional
libpff1_20120802-2_amd64.deb
2a15da8fb32b526714c5868a3d364e43 829780 debug extra
libpff-dbg_20120802-2_amd64.deb
1c765a596e59db417f1eb4e51f816aa9 449192 libdevel optional
libpff-dev_20120802-2_amd64.deb
e5d021e0fc3443a5c9fa673291dfb1eb 355080 admin optional
pff-tools_20120802-2_amd64.deb
473f7dc25d1c866e64946dcb1fed661c 1777 libs optional libpff_20120802-2.dsc
be93fd43893b4d0537f7b6bf157bc5a3 8128 libs optional
libpff_20120802-2.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQEcBAEBAgAGBQJT/tQfAAoJEFqCeQfe0MQYfNsH/jdgzadNri/R/umtjYTbQsm3
NiAAGVvrT/FA15/nlKIcrWxh2kBXxHRu6/sVV+TMOyB7WjPxLm/vvxXaJzgdLw6m
SQitOkFQtx7Kowo9/ZEMbY5nloPvGlES858xsS/dE5hC0pQK6O/FF6EzlWLxfY2W
wpNGbBQIa5MVZ81Fl8+BgQzk10ZxX4RMbRsTW94T+z5pWRAzyQQofHpUJyx3bYVZ
YZx5q4STBanZoz9GXB08TQc2pAUw/0YoQnlTDcM6tcFAMD2YJwW65+2blRiStkBF
0SuACFjSnNLSPgiSTHWMc8OdLZNht4aM3iLL4nbWWhJx9pUkLSP1LememMXXR6s=
=9oME
-----END PGP SIGNATURE-----
--- End Message ---
_______________________________________________
forensics-devel mailing list
[email protected]
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/forensics-devel
