António just committed:
+ postScript = ('#!/bin/bash\n'
+ '/sbin/service memcached restart\n'
+ '/sbin/service httpd restart\n')
+ r.ScriptPostInstall(contents=postScript)
+ r.ScriptPostUpdate(contents=postScript)
This will break image builds. It can also cause problems on
the machine hosting image builds.
The "condrestart" action is there precisely for this case.
That is "restart only if it's already started".
However, that's still not good enough, because it terminates
existing sessions. We have "graceful" which is probably functional
for this (I don't think apachectl will magically start the service)
but I suspect will complain if it's not started. So we could, I
guess, add "condgraceful" for the purpose of tag/trove scripts.
While adding "condgraceful" to httpd and using condrestart for
memcached is probably a good idea, it is important to solve the
underlying problem of "I can't updated if httpd is not running"
by having a DIRECT fallback in the proxy configuration.
Rune is fixing that correctly:
# By default, always go through the proxy
proxyMap * conary://localhost:8008/conary/
# Fallback if the proxy is down (file is parsed in order)
proxyMap * DIRECT
_______________________________________________
Foresight-devel mailing list
[email protected]
https://lists.foresightlinux.org/mailman/listinfo/foresight-devel
