single is a very particular case of initscript, has no runlevels et al.
The only gain we get from TagSpecing it is to have the tag handler/
chkconfig making noise complaining about the run levels, (which
in this case is ok not to be there present ) so untagSpecing it
in this case is the right thing to do as it make the boot/trove
update process a bit less noisy.
António
On 08/11/2010 04:40 AM, Andy Grimm wrote:
> On Tue, Aug 10, 2010 at 11:24 PM, Jesse Zhang <zh.je...@gmail.com> wrote:
>
>> On Wed, Aug 11, 2010 at 9:08 AM, Michael K. Johnson <johns...@rpath.com>
>> wrote:
>>> In initscript.recipe I see:
>>> #r.TagSpec('initscript', exceptions='%(initdir)s/single')
>>>
>>> When updating I keep getting the error:
>>> [initscript] service single does not support chkconfig
>>>
>>> which is indeed true.
>>>
>>> Why is that TagSpec exception commented out?
>> If our recipes are managed with some distributed VCS, such things
>> would be obvious. Or at least easy to find who is to blame:
>>
>> commit eb9ba29da013edded57251f809c0f29767695ab6
>> Author: Antonio Meireles aka doniphon <s...@reboot.sh>
>> Date: Thu Oct 23 22:50:32 2008 +0000
>>
>> sync with rPL initscripts tree
>>
>> cvc revision: 8.81.2-0.1
>>
>> [snip]
>> @@ -115,11 +107,11 @@ class Initscripts(RPMPackageRecipe,CPackageRecipe):
>> r.TagSpec('initscript', '%(initdir)s/')
>> r.TagSpec('initscript', exceptions='%(initdir)s/killall')
>> r.TagSpec('initscript', exceptions='%(initdir)s/halt')
>> - r.TagSpec('initscript', exceptions='%(initdir)s/single')
>> + #r.TagSpec('initscript', exceptions='%(initdir)s/single')
>> r.TagSpec('initscript', exceptions='%(initdir)s/functions')
>> r.RequireChkconfig(exceptions='%(initdir)s/killall')
>> r.RequireChkconfig(exceptions='%(initdir)s/halt')
>> - r.RequireChkconfig(exceptions='%(initdir)s/single')
>> + #r.RequireChkconfig(exceptions='%(initdir)s/single')
>> r.RequireChkconfig(exceptions='%(initdir)s/functions')
>>
>> [snip]
>>
>> So the change was made years ago, and taken from rPL.
>>
> The hg tree was probably synced with rPL in this version, but the recipe
> change did not come from rPL.
>
> --Andy
> _______________________________________________
> Foresight-devel mailing list
> Foresight-devel@lists.rpath.org
> http://lists.rpath.org/mailman/listinfo/foresight-devel
_______________________________________________
Foresight-devel mailing list
Foresight-devel@lists.rpath.org
http://lists.rpath.org/mailman/listinfo/foresight-devel
