Ping! Ok for trunk?
I have looked at other patches, but none was patching any location I have worked on previously. Therefore I can't return the favor of reviewing any currently open patches and have to ask for volunteers here. - Andre On Mon, 26 Apr 2021 12:36:36 +0200 Andre Vehreschild via Fortran <fortran@gcc.gnu.org> wrote: > Hi Steve, hi all, > > I agree. The cas-things have been removed (I will put the patch for them into > the pr98301 ticket, so safe them), streamlining the patch a bit more. > > Bootstraped and regtested ok on x86_64-linux/f33. Ok for trunk? > > Regards, > Andre > > Steve Kargl <ka...@gcc.gnu.org> > > PR fortran/98301 - random_init() is broken > > Correct implementation of random_init() when -fcoarray=lib is given. > > gcc/fortran/ChangeLog: > > PR fortran/98301 > * trans-decl.c (gfc_build_builtin_function_decls): Move decl. > * trans-intrinsic.c (conv_intrinsic_random_init): Use bool for > lib-call of caf_random_init instead of logical (4-byte). > * trans.h: Add tree var for random_init. > > libgfortran/ChangeLog: > > PR fortran/98302 > * caf/libcaf.h (_gfortran_caf_random_init): New function. > * caf/single.c (_gfortran_caf_random_init): New function. > * gfortran.map: Added fndecl. > * intrinsics/random_init.f90: Implement random_init. > > > > On Sun, 25 Apr 2021 13:03:34 -0700 > Steve Kargl <s...@troutmask.apl.washington.edu> wrote: > > > Andre, > > > > The patch looks fine to me. I wonder, however, if we should > > comment out all of the shared memory stuff, i.e., the _cas_ > > stuff. I don't know when Thomas/Nicolas will merge their > > work-in-progress. > > > > > -- > Andre Vehreschild * Email: vehre ad gmx dot de -- Andre Vehreschild * Email: vehre ad gmx dot de