On Fri, May 28, 2021 at 12:59:20AM +0200, Tobias Burnus wrote:
> * gfortran.dg/gomp/depend-iterator-1.f90: New test.
> * gfortran.dg/gomp/depend-iterator-2.f90: New test.
Something I've missed during the review but it shows up during testing:
> diff --git a/gcc/testsuite/gfortran.dg/gomp/depend-iterator-1.f90
> b/gcc/testsuite/gfortran.dg/gomp/depend-iterator-1.f90
> new file mode 100644
> index 00000000000..cad36aaf8b7
> --- /dev/null
> +++ b/gcc/testsuite/gfortran.dg/gomp/depend-iterator-1.f90
> @@ -0,0 +1,45 @@
> +! { dg-do run }
gcc/testsuite/*/gomp/ shouldn't have dg-do run tests, either
it is meant to be a runtime test and then it should be moved to
libgomp/testsuite/libgomp.fortran/ , or it should be changed to
dg-do compile.
> --- /dev/null
> +++ b/gcc/testsuite/gfortran.dg/gomp/depend-iterator-2.f90
> @@ -0,0 +1,44 @@
> +! { dg-do run }
And this one has dg-error in it, so this one must be dg-do compile.
> + !$omp task depend (iterator (j=i:i+1) , out : foo (j)) ! { dg-error
> "is not a variable" }
> + arr(i) = i
> + !!$omp end task
> + !$omp task depend(iterator(i=1:5), source ) ! { dg-error "ITERATOR may
> not be combined with SOURCE" }
> + !!$omp end task
> + !$omp task affinity (iterator(i=1:5): a) depend(iterator(i=1:5), sink : x)
> ! { dg-error "ITERATOR may not be combined with SINK" }
Jakub
