Re: Multiple Set Methods on Models

[Shawn McKinney]

> On Jan 5, 2016, at 10:35 AM, Chris Pike <clp...@psu.edu> wrote:
> 
> There are a couple instances where models have multiple set methods for the 
> same field. 
> 
> UserAdminRole has...
> 
>    public void setOsP( String osP )
>    public void setOsP( Set<String> osPs )
> 
>    public void setOsU( Set<String> osUs )
>    public void setOsU( String osU )
> 
> User has...
> 
>    public void setRole( String roleName )    
>    public void setRole( UserRole role )
> 
>    public void setAdminRole( UserAdminRole role )
>    public void setAdminRole( String roleName )
> 
> This is causing some issues down the line with jackson. I have a workaround 
> but wanted to see if there was any possibility of changing one of the method 
> names.

I don’t have any objections.  Before committing it needs to pass tests.  

This will require:
a. run fortress junit tests
b. run fortress junit tests via rest (by setting enable.mgr.impl.rest=true)
c. run fortress web selenium tests

Here are my recommendation for new names:

User:
setRoleRaw( String roleName );
setAdminRoleRaw( String roleName );

UserAdminRole:
setOsPs( Set<String> osPs );
setOsUs( Set<String> osUs );

The other methods can remain as they are.

Shawn