> > On Jan 8, 2016, at 2:05 PM, Chris Pike <[email protected]> wrote: > > No need to redo it, github could have automatically merged the pull request. > I rebased our branch, so now the commit history will look like the changes in > the pull request came after all of your javadoc cleanup.
OK Good. I just accepted the pull request. Another change to method name - used ‘set’ in the name instead of ‘list’ for obvious reasons. Let me know if you have any problems. > > On Jan 8, 2016, at 2:05 PM, Chris Pike <[email protected]> wrote: > > No need to redo it, github could have automatically merged the pull request. > I rebased our branch, so now the commit history will look like the changes in > the pull request came after all of your javadoc cleanup. > > I still haven't been able to get the audit manager tests to pass, regardless > of how I change the build.properties, the same 5 tests always fail. We need to get you past this somehow. I recommend we hop on IRC sometime next week and figure it out. Thanks for the help, Shawn
