> On Jan 30, 2016, at 9:20 AM, Chris Pike <[email protected]> wrote:
> 
> Here are the new methods I've added to the manager. I added documentation for 
> each 
> (https://github.com/PennState/directory-fortress-core-1/tree/feature/addPermAttrAndUserRoleConstraints).

Chris, I downloaded a tarball using this link: 
https://github.com/PennState/directory-fortress-core-1/tree/feature/addPermAttrAndUserRoleConstraints.
  But how do I pull a local copy of this tree using the ‘git clone’ command?  I 
wasn’t able to do it.  Not a big deal, but can’t synch as easily, using 'git 
pull’.

> On Jan 30, 2016, at 9:20 AM, Chris Pike <[email protected]> wrote:
> 
> I started adding new unit tests, but they are not complete yet and I have 
> some validation checks to add, but basic functionality is working. 
> 


Good.  Can you run the full unit tests in your local env yet, i.e. are tests 
still failing? 

> On Jan 30, 2016, at 9:20 AM, Chris Pike <[email protected]> wrote:
> 
> Additionally, reading permissions will populate the attributeSetName (just 
> name, does not load ftAttributeSet object) and reading roles will populate 
> the roleConstraints (from ftRCs).

Code looks good.  When does the addRoleConstraint method get called?  Will 
assigning a role to a user now be a two-step process?

> On Jan 30, 2016, at 9:20 AM, Chris Pike <[email protected]> wrote:
> 
> Let me know if you have any issue or concerns.

Let’s get before & after performance impacts of these changes (once inserted 
into access mgr).  There is a short section in the README of how to run the 
jmeter tests.  I recommend tests A & B.  We’ll definitely want same for 
sessionPermissions but I’ll need to add the test case.  Let me know if you need 
help getting this running.

___________________________________________________________________________________
## SECTION 14. Instructions to performance test

 This section describes the Apache Fortress jmeter test programs.

1. Load the security policy and users required by the jmeter test routines:

 ```
 mvn install -Dload.file=./ldap/setup/LoadTestUsers.xml
 ```

2. The .jmx files located in [.src/test/jmeter](.src/test/jmeter) folder are 
used to control test settings for the following:

 A. Fortress CheckAccess:
  [src/test/jmeter/ftCheckAccess.jmx](src/test/jmeter/ftCheckAccess.jmx)

 B. Fortress CreateSession:
  [src/test/jmeter/ftCreateSession.jmx](src/test/jmeter/ftCreateSession.jmx)

3. From **FORTRESS_HOME** folder, enter the following command from a system 
prompt:

 A. Fortress CheckAccess:
  ```
  mvn -Ploadtest-ftca jmeter:jmeter
  ```

 B. Fortress CreateSession:
  ```
  mvn -Ploadtest-fortress-createsess
  ```

Shawn

Reply via email to