Chris,
Can you explain the rationale of changing this method label name?
@Override
public List<Permission> findPermissions(PermObj permObj)
throws SecurityException {
String methodName = "findPermissions”;
As a convention every method has a unique label (even the overloaded ones) in
order to control them via ARBAC permissions. For this method, we have this
corresponding permission that is loaded:
<permgrant
objName="org.apache.directory.fortress.core.impl.ReviewMgrImpl"
opName="findPermObjs" roleNm="fortress-core-super-admin" admin="true”/>
By changing the name we can no longer differentiate between that one and this
one:
public List<Permission> findPermissions(Permission permission)
throws SecurityException
{
String methodName = "findPermissions”;
Please advise,
Shawn
> Begin forwarded message:
>
> Reply-To: [email protected]
> From: [email protected]
> To: [email protected]
> Subject: directory-fortress-core git commit: fixed method name in
> findPermission(permObj) method
> Date: March 21, 2016 at 9:13:19 AM CDT
>
> Repository: directory-fortress-core
> Updated Branches:
> refs/heads/master ff50d8f1e -> d14990b69
>
>
> fixed method name in findPermission(permObj) method
>
>
> Project: http://git-wip-us.apache.org/repos/asf/directory-fortress-core/repo
> Commit:
> http://git-wip-us.apache.org/repos/asf/directory-fortress-core/commit/d14990b6
> Tree:
> http://git-wip-us.apache.org/repos/asf/directory-fortress-core/tree/d14990b6
> Diff:
> http://git-wip-us.apache.org/repos/asf/directory-fortress-core/diff/d14990b6
>
> Branch: refs/heads/master
> Commit: d14990b69e2181ef46ba7692c7e98f6ae6307914
> Parents: ff50d8f
> Author: clp207 <[email protected]>
> Authored: Mon Mar 21 10:13:06 2016 -0400
> Committer: clp207 <[email protected]>
> Committed: Mon Mar 21 10:13:06 2016 -0400
>
> ----------------------------------------------------------------------
> .../org/apache/directory/fortress/core/impl/ReviewMgrImpl.java | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/d14990b6/src/main/java/org/apache/directory/fortress/core/impl/ReviewMgrImpl.java
> ----------------------------------------------------------------------
> diff --git
> a/src/main/java/org/apache/directory/fortress/core/impl/ReviewMgrImpl.java
> b/src/main/java/org/apache/directory/fortress/core/impl/ReviewMgrImpl.java
> index 0b04f28..83dc671 100755
> --- a/src/main/java/org/apache/directory/fortress/core/impl/ReviewMgrImpl.java
> +++ b/src/main/java/org/apache/directory/fortress/core/impl/ReviewMgrImpl.java
> @@ -133,7 +133,7 @@ public class ReviewMgrImpl extends Manageable implements
> ReviewMgr, Serializable
> @Override
> public List<Permission> findPermissions(PermObj permObj)
> throws SecurityException {
> - String methodName = "findObjPermissions";
> + String methodName = "findPermissions";
> assertContext( CLS_NM, methodName, permObj,
> GlobalErrIds.PERM_OBJECT_NULL );
> VUtil.assertNotNullOrEmpty(permObj.getObjName(),
> GlobalErrIds.PERM_OBJECT_NM_NULL, CLS_NM + "." + methodName);
> checkAccess(CLS_NM, methodName);
>
