1. I did this a while back, but I'll do it again 2. Yes... any chance there is eclipse formatting profile I can use? 3. Yes, I already added docs for a lot of the methods, but will go back through and add anything I missed 4. Yes 5. Yes
----- Original Message ----- From: "Shawn McKinney" <[email protected]> To: [email protected] Sent: Thursday, September 15, 2016 10:57:45 AM Subject: Re: Fortress Filter Constraints Implemented Hello Chris, Yes I was beginning to wonder what happened to this. Good to hear the work is nearly complete. Here are my questions / comments 1. Were you able to run performance tests on createSession and sessionPermissions to see if there is impact to performance there? 2. Can you follow the project guidelines for code formatting? Seems were not quite the same here. 3. Can you add the javadoc for these new classes and methods? 4. Were unit tests added to verify this functionality? 5. Have the fortress junit tests passed? Once we’ve got these items covered I’d say go ahead and commit your changes. Shawn > On Sep 15, 2016, at 8:08 AM, Chris Pike <[email protected]> wrote: > > Shawn, > > A while back we discussed adding a new type of Role Constraint to support > "attribute" based permissions > (http://mail-archives.apache.org/mod_mbox/directory-fortress/201601.mbox/browser). > I think I'm almost ready to merge into master, but would like you to take a > look since there are a lot of changes. > (https://github.com/PennState/directory-fortress-core-1/tree/feature/addPermAttrAndUserRoleConstraints). > > The high level overview > > 1. Permissions can now point at one to many Permission Attribute Sets (paSet) > 2. A paSet defines one to many Permission Attributes (pa) > 3. There is now a new FILTER role constraint type. Fortress doesn't care > about the actual value of the role constraint, so it is up to client to set > and use the constraint data however they want. > > Thanks, > > ~Chris P.
