This message is from the T13 list server.

More comments from Rob Elliott.

Regards, Pete


-----Original Message-----
From: Elliott, Robert (Server Storage) [mailto:[EMAIL PROTECTED]]
Sent: Friday, December 06, 2002 4:19 PM
To: Mclean, Pete
Subject: ata7v1r1a editorial (mostly) comments


>From reviewing the ATA command tables, here are a few editorial comments
on tables in ata7v1r1a.

1. Tables B.2 and B.3 currently have the same title - Command codes.
Since they're back-to-back, I suggest changing them to have slightly
different names:
B.2 Command codes (sorted by command code)
B.3 Command codes (sorted by command)

2. Numerous tables (1, 5, 7, 11, ... B.2, B.3) don't show up in the
Table of Tables on page 9.

3. The Table 1 (page 14) caption is below rather than above the table.

4. Table 15 (page 121-130) has pagination problems - e.g. page 128 just
has a caption.

5. There are no text references to table 32, 33, and 34 (page 204).
They are referenced from table 31; a one line introduction in the main
text to each would be nice.

6. There is no text references to table 41 (page 257).  It is referenced
from table 40; a one line introduction in the main text would be nice.

7. Table 61's caption is not on the same page as the table (page
302-303).

8. The reference to Figure 8 on page 33 should be to Figure 4.

9. Figure 5 lacks an introduction in the text (pages 29-30).

10. The introduction to Figure C.1 is after the figure; before would be
more consistent.

11. Many Figures don't show up in the Table of Figures (e.g. 1,3, 5, 9,
C.1) on page 10.

12. Section 4.3.2 says the following General feature set commands are
mandatory for all devices implementing the PACKET command feature set:
IDENTIFY DEVICE and READ SECTOR(S).

However, table B.2 lists both of these "N" for Packet devices.

13. Page 33 "A Master password may be set in a addition to the User
password." remove the extra "a ".

14. Page 38 In "Devices that implement the PACKET Command feature set
shall not implement the SMART feature set as described in thisstandard"
change "thisstandard" to "this standard".

15. In tables B.2/B.3 change "SMART EXECUTE OFF_LINE" to "SMART EXECUTE
OFF-LINE IMMEDIATE"

16. In tables B.2/B.3 drop "SECTOR" from both "SMART READ LOG SECTOR"
and "SMART WRITE LOG SECTOR"

17. Add "(SMART)" to the section 4.8 header before "feature set"

18. On page 47 "READ VERIFY SECTOR(S)" should be "READ VERIFY SECTOR(S)
EXT" - this is the list of 48-bit commands

19. In tables B.2 and B.3, spell out "WITHOUT" rather than use "W/OUT"
for "CFA WRITE MULTIPLE WITHOUT ERASE" and "CFA WRITE SECTORS WITHOUT
ERASE".  This allows global searches.

20. In tables B.2 and B.3, add:
PO   SET MAX SET PASSWORD
ND   SET MAX LOCK
ND   SET MAX FREEZE LOCK
PO   SET MAX UNLOCK
each with a Command field of F9h.  (They're commands listed for Host
Protected Area + security extensions feature sets)

21. The Media Card Pass Through Command feature set introduction (4.16)
and description (6.6) don't mention that it's prohibited from use with
Packet feature set, but tables B.2 and B.3 label it "N".

22. The CFA feature set introduction (4.10) and description (6.1-6.5)
don't mention that they are prohibited from use with Packet feature set,
but tables B.2 and B.3 label them "N".

23. In Tables 21 and 22, I suggest adding a column titled "Feature set"
and indicate for each command which feature set it comes from.  The
commands that come from more than one feature set (ORed) or require more
than one feature set (ANDed) are:
MEDIA EJECT = Removeble Media or Removable Media Status
READ DMA QUEUED EXT = 48-bit Address and Queued
READ LOG EXT = General Purpose Logging or Streaming or SMART
READ NATIVE MAX ADDRESS EXT = 48-bit Address and Host Protected Address
SET MAX ADDRESS EXT = 48-bit Address and Host Protected Address
WRITE DMA QUEUED EXT = 48-bit Address and Queued
WRITE DMA QUEUED FUA EXT = 48-bit Address and Queued
WRITE LOG EXT = General Purpose Logging or Streaming or SMART

24. Tables 21 and 22 use M for mandatory, O for optional, and N for
prohibited.  There are really more granularities - for example:

Mandatory  (General feature set)
Mandatory if writing media is supported
Mandatory if xyz feature set is supported
Mandatory if xyz feature set and abc feature set are both supported
Mandatory if xyz feature set or abc feature set are supported
Optional if xyz feature set is supported

The current use of M and O seems inconsistent.  CHECK POWER MODE is
listed as M for packet devices, but it's really only mandatory if the
Power Management feature set is supported by the packet device.  The
same for IDLE IMMEDIATE, SLEEP and STANDBY IMMEDIATE.  With a feature
set column added, M could be defined to mean "mandatory if indicated
feature sets are supported" and O could be defined to mean "optional if
indicated feature sets are supported".

The SMART commands also have this distinction: SMART DISABLE OPERATIONS,
ENABLE/DISABLE AUTOSAVE, ENABLE OPERATIONS, and RETURN STATUS are all
mandatory if the SMART feature set is implemented; the rest are optional
if the SMART feature set is implemented.

>From the general feature set, FLUSH CACHE, WRITE DMA, WRITE MULTIPLE,
and WRITE SECTOR(S) are only mandatory if writing is supported.  (all
their optional cousins from other feature sets inherit that assumption
too, e.g. FLUSH CACHE EXT)

25. Several of the EXT commands are labeled N for packet devices, but
there is no text that says they are prohibited in the 48-bit model and
their non-EXT cousins are not prohibited.
FLUSH CACHE EXT
READ NATIVE MAX ADDRESS EXT
SET MAX ADDRESS EXT

Either they should be allowed or prohibited consistently.

26. Section 4.3.2 says IDENTIFY DEVICE and READ SECTOR(S) are mandatory
for packet devices, but table B.2/B.3 mark them as "N".

27. Why is READ SECTOR(S) EXT prohibited for packet devices if READ
SECTOR(S) is mandatory?

28. Section 6.15 says GET MEDIA STATUS is optional for Removable Media
feature set, but 4.11.2 does not mention it.

29. In tables B.2/B.3 WRITE DMA QUEUED FUA EXT should be "DMO" not "DM".
The protocol section 6.62.3 should say DMA QUEUED not DMA. 

30. In tables B.2/B.3, change DMO to DMQ.  O implies Output (PI and PO
use that convention).

31. In tables B.2/B.3 change SERVICE from P to "P or DM"

32. In 6.70.2 Change "of" to "if" in "Mandatory of the"

33. Globally choose one of "PACKET feature set" or "PACKET Command
feature set".

34. Change 4.10 from "CFA feature set" to "CompactFlashtm Association
(CFA) feature set"

35. To better prepare for Serial ATA, create a model clause defining
generically what PIO In/Out, DMA, DMA Queued, etc. "protocol"s mean.
Change all the "(see clause 11)" references (in each command
description) to point to that section.  In that section, mention that
transport protocols like ATA7V2 define the terms in more detail.

36. I recommend making Table B.3 normative and placing it at the
beginning of clause 6.

37. In 2.3 add "http://"; before all the web site names (www.qic.org and
www.pc-card.org)


--
Rob Elliott, [EMAIL PROTECTED]
Hewlett-Packard Industry Standard Server Storage Advanced Technology
https://ecardfile.com/id/RobElliott

Reply via email to