On Mon, 19 Jul 2021, Deepak Kumar wrote:
Its overall good. Specifically, I liked the proposal/premise of keeping mainline(strikr) *ready to ship* always. However, this has a challenge as sometimes a PR commit can cause build breakage or test failure. In this case, will we adopt the approach to auto-backout the PR?
a Pull Request (PR) branch is created from a fork of the 'strikr' branch (aka main | master) of the repository ! a useful PR is backed by a test case and a clean build. if not then the following will be seen - a wrong commit - a revert commit to undo the changes of the wrong commit this pollutes the commit history ! a contributor should - find out the wrong commit - pick the wrong commit - remove the wrong commit - rebase - test - push the changes. IMHO, this is a pragmatic approach to keep the 'strikr' branch 'ready to ship' ! warm regards Saifi.
