On 3/23/2016 5:18 PM, Joe Mistachkin wrote:
Ross Berteig wrote:
I contrast that with using make -f win/Makefile.mingw which as I noted
earlier did assume the in-tree zlib and importantly, build it.
Yeah, I implemented the assume-and-build-zlib-in-tree stuff for MinGW a
while back; however, it was not normally needed for non-Windows systems
(i.e. because they already have a system zlib) and so the normal POSIX
configure & make stuff got skipped.
I suppose it should be added at some point.
I don't think it is show stopper by any means.
But when in-tree zlib is selected even on a system that provides a zlib,
it seems natural to build it along with fossil regardless of platform
and so forth. The configuration built can (and should) be optimized to
exactly what fossil needs, likely a static library to avoid picking up
the system version.
If a system zlib is selected by configure, naturally it is already built
and installed and should be used.
Things are quirky on Windows where "and installed" has a surprisingly
weak meaning for most tool chains dealing with third-party libraries.
I imagine things are also quirky for cross compilation. I have a (now
shockingly out of date, I really ought to fix that) cross-compiled
fossil running in a DNS-323 network storage box for instance. Built with
GCC from an x86 linux box, targeting a particular flavor of ARM and
libc. I don't recall what I used for zlib when I built it.
In both of those cases, I suspect that an out-of-tree build would
benefit if zlib were also built out-of-tree. It looks like
--with-zlib=tree assumes that both zlib.h and zlib.a are found in
compat/zlib in the source tree.
I'd just go say "./configure; make" in compat/zlib if I had some
confidence that would produce the right configuration of the library.
--
Ross Berteig [email protected]
Cheshire Engineering Corp. http://www.CheshireEng.com/
+1 626 303 1602
_______________________________________________
fossil-dev mailing list
[email protected]
http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/fossil-dev
