On Tue, Dec 2, 2014 at 1:10 AM, Andy Bradford <amb-fos...@bradfords.org> wrote:
> Thus said Richard Hipp on Mon, 24 Nov 2014 07:35:55 -0500: > > > (1) Bundles. A bundle is a single file (another SQLite database, of > > course) that encapsulates one or more check-ins. An unprivileged user > > can clone a repo and make their own local changes, then package those > > changes into a bundle to email to a developer for consideration. The > > developer can then import a bundle into a provide branch for > > examination. Then either purge that private branch or publish it, as > > appropriate. > > > I started looking at the bundle command and have some questions. It > looks like doInit was intended to be used by bundle_attach_file(): > > > http://www.fossil-scm.org/index.html/info/ce6ca619540fc1bd3639bd0cd9b540278859bcd4?ln=52,59 > > but it doesn't do anything, and in fact, I expected it to wipe out an > existing bundle that I had created (from bundle_export_cmd()), but > instead it appended to it. What should doInit==1 actually cause to > happen? > doinit is a placeholder. I intended it to be TRUE if the bundle file is allowed to be created if it does not exist, or FALSE to raise an error if the file is does not already exist or is not a valid bundle file. So doInit was intended to be like the O_CREAT flag on open(). > > Should another parameter be added bundle_attach_file() check to see if > the file exists prior to actually attempting to attach. For example, > ``fossil bundle ls notafile'' will create an empty bundle called > ``notafile'' but perhaps it should should have instead exited with an > error? The same question for cat, purge, append, etc. where a file would > be expected to exist prior to using it or an error occurs? > > I started to add an additional parameter, but then it became ambiguous > what doInit=1 and bCheckexists=1 meant for bundle_cat_cmd() where doInit > is passed in as 1. Is doInit=1 parameter for bundle_cat_cmd() is > incorrect? > > > http://www.fossil-scm.org/index.html/info/2147bffe4484d19ae34e28b208c2037b233b6167?ln=513,518 > > Also, I added additional checks to verify that where a file is > expected, we have the right number of arguments, otherwise sometimes > bundle_attach_file() will create files when not really expected: > > > http://www.fossil-scm.org/index.html/info/9f63c8a3fe1ea68d135793e29697f346ed0299ce > > > Another item I noticed is when I import a bundle, the new Artifacts > Receipts Log has no values for User or IP Address. Should it? > > Looking good so far... > > Thanks, > > Andy > -- > TAI64 timestamp: 40000000547d5809 > > > -- D. Richard Hipp d...@sqlite.org
_______________________________________________ fossil-dev mailing list fossil-dev@lists.fossil-scm.org http://sqlite.org:8080/cgi-bin/mailman/listinfo/fossil-dev
