Hello, Just a quick note regarding this commit:
http://www.fossil-scm.org/index.html/info/2d714a4e48251549 I ran into a segfault while testing some of the amend command changes. Specifically, where I ran into it, was with: http://www.fossil-scm.org/index.html/artifact/212114657df8d3ccf84ec056db4ca1c003253543?txt=1&ln=1002%201005 Where zInit ended up actually being NULL, and blob_append didn't check because the second argument is -1, which ended up in a strlen(0x0) and a segfault. Perhaps instead of an assertion here, would it be more appropriate to just return, because clearly it isn't possible to append to the blob. But maybe this is an exceptional situation that warrants the assert()? Thanks, Andy -- TAI64 timestamp: 4000000055bda824 _______________________________________________ fossil-dev mailing list fossil-dev@mailinglists.sqlite.org http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/fossil-dev