On 1/9/2016 11:19 AM, Joe Mistachkin wrote:
Ross Berteig wrote:
At this point I have ask whether the test cases in test/file1.test or
the code in src/file.c are correct?
The tests assumed they were running from the Fossil source checkout. The
"file1" and "th1" test files have now been fixed to no longer assume that;
however, certain tests in the "th1" test file need to still assume (rightly)
that the Fossil source checkout is available (via the directory containing
the "tester.tcl" file).
I updated to latest trunk, and those changes helped file1.test
immensely. Run from out of the tree, it now reports 0 error of 58 tests run.
I still have errors from th1.test: 3 errors out of 255 tests run. They
are th1-checkout-2, th1-globalState-1, and th1-globalState-8.
I re-ran the whole suite from out of tree. Now the failing tests for the
whole suite are:
* merge-utf-27-23
* merge-utf-27-32
* merge_multi-4
* merge_renames-5
* th1-checkout-2
* th1-globalState-1
* th1-globalState-8
Those tests (and only those tests), save the current directory, change the
current directory to be within the Fossil source checkout, run the Fossil
command being tested, and then restore the current directory. The new test
code that does this can be seen on trunk.
That's a way out that didn't occur to me. I was visualizing adding
enough code to the test case to set up the conditions it was now
assuming existed in the main repository, and not relishing the effort
required to work that out.
Thanks for helping us improve this stuff.
Glad to help. Testing is important, if unglamorous.
--
Ross Berteig r...@cheshireeng.com
Cheshire Engineering Corp. http://www.CheshireEng.com/
_______________________________________________
fossil-dev mailing list
fossil-dev@mailinglists.sqlite.org
http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/fossil-dev
