On 2/29/2016 3:50 PM, Joe Mistachkin wrote:
I think the "fix" here is to have both places check all the variables in a well-defined order, e.g. FOSSIL_USER should [still] be first, followed by the variables for POSIX, and finally those for Windows.
Sounds sensible to me. Setting variables that "belong" to the other platform is sometimes a recipe for confusion, but doing fewer things in platform-specific ways is easier to document and easier to understand.
The other differences are clearly the result of different end goals. The one case is trying to guess a sensible name for the admin user of a new repository. The other is trying to actually log in.
One other difference is that the --user global option is apparently ignored in db_create_default_users(), unless the caller chose to use it to inform the zDefaultUser parameter passed to it. That doesn't appear to happen. I'm not sure that is important. fossil new and clone have --admin-user for that purpose, for example.
Interestingly, --user is used by fossil server --create and fossil ui --create to set the default user name, an option I didn't know existed until just now.
-- Ross Berteig r...@cheshireeng.com Cheshire Engineering Corp. http://www.CheshireEng.com/ +1 626 303 1602 _______________________________________________ fossil-dev mailing list fossil-dev@mailinglists.sqlite.org http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/fossil-dev
