On 3/2/2016 10:47 AM, Joe Mistachkin wrote:

Please review and/or run tests against the test suite changes on the
"testerCleanup" branch.  It's designed to give each test file its very
own isolated set of test directories (one for each call to repo_init).
It's also designed to cleanup after itself.  Finally, it is designed
so that it no longer matters if it's run from an open checkout.  For
now, I've left the "no open checkout" restrictions in place for the
specific test files that have it; however, technically it no longer
matters.

Updated to testerCleanup in my Windows box. Configured and built clean, then ran all tests from an MSYS bash prompt:

$ ../fossil4/configure --with-miniz --with-openssl=none --json --with-tcl --with-tcl-stubs --with-tcl-private-stubs --with-th1-docs --with-th1-hooks
$ make clean; make
$ tclsh ../fossil4/test/tester.tcl  ./fossil -quiet -prot
....
***** Final results: 3 errors out of 29799 tests
***** Considered failures: stash-3-4-mv stash-4-2-diff-CODE stash-4-3-diff-CODE
***** Ignored results: 10 ignored errors out of 29799 tests
***** Ignored failures: json-cap-POSTenv-name json-ROrepo-2-2 json-ROrepo-2-3 merge_multi-4 merge_renames-5 stash-WY-1-CODE stash-2-1-CODE stash-3-2 stash-3-2-show-1 stash-3-2-pop-changes

I'm not seeing the failures you reported in the commit comment for amend-comment-5-1, amend-comment-5.2, amend-comment-5.3, amend-comment-5.4, and json-1.

I want to verify the stash failures are right.

Having json-1 file probably indicates that you didn't make clean after running configure --json. It checked that "fossil json" failed and produced a JSON object containing the expected JSON error code. That failing "can't happen" if json mode is configured and built right.

I also want to see it run in my Ubuntu box which I will do real soon now.

--
Ross Berteig                               r...@cheshireeng.com
Cheshire Engineering Corp.           http://www.CheshireEng.com/
+1 626 303 1602
_______________________________________________
fossil-dev mailing list
fossil-dev@mailinglists.sqlite.org
http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/fossil-dev

Reply via email to