Hello, While looking at a recent bug reported on the fossil-users list, I realized that file_simplify_name() has a problem:
http://www.fossil-scm.org/index.html/artifact?ln=802+841&name=c77e7c7383f414c6 Specifically, it doesn't check that z is not NULL. This later results in a segfault (line 841). Should file_simplify_name: a) return 0 in the case that either z is NULL or n is 0, thus assuming that the caller wants have a relative path (see reference below)? or b) assert that z is not NULL and force the caller to always provide a path? In this case, a relative path is achieved by passing in the empty string, not NULL. I'm leaning towards b, but am willing to hear arguments for a; or is there another option? Thanks, Andy -- TAI64 timestamp: 400000005927b1d4 _______________________________________________ fossil-dev mailing list fossil-dev@mailinglists.sqlite.org http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/fossil-dev
