Hi,

Minimal fix: remove unused variable in Check-in [92ea6183]


Index: src/file.c
==================================================================
--- src/file.c
+++ src/file.c
@@ -626,11 +626,11 @@
 **
 ** On success, return zero.  On error, return errorReturn if
positive, otherwise
 ** print an error message and abort.
 */
 int file_mkfolder(const char *zFilename, int forceFlag, int errorReturn){
-  int i, nName, rc = 0;
+  int nName, rc = 0;
   char *zName;

   nName = strlen(zFilename);
   zName = mprintf("%s", zFilename);
   nName = file_simplify_name(zName, nName, 0);


BR,
Johan


On Wed, Aug 23, 2017 at 6:33 PM, Richard Hipp <d...@sqlite.org> wrote:
> On 8/23/17, Richard Hipp <d...@sqlite.org> wrote:
>> The problem originates at this check-in:
>> https://fossil-scm.org/fossil/timeline?c=2375d6cbce933267
>
> I do not understand what benefit the check-in above provides.  But it
> does definitely change the semantics of a lot of operations,
> complicate the code, and introduce bugs.  So I am inclined to back
> that change out.
>
> If you are using the --no-dir-symlinks option and/or think it should
> remain in the code, then you have 24 hours to make your case.  In the
> absence of a compelling reason to keep the --no-dir-symlinks, and a
> promise for fixes to the code, I will back out that capability at the
> conclusion of the comment period.
> --
> D. Richard Hipp
> d...@sqlite.org
> _______________________________________________
> fossil-dev mailing list
> fossil-dev@mailinglists.sqlite.org
> http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/fossil-dev
_______________________________________________
fossil-dev mailing list
fossil-dev@mailinglists.sqlite.org
http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/fossil-dev

Reply via email to