On Jun 20, 2018, at 3:44 PM, Warren Young <war...@etr-usa.com> wrote: > > Except now it has mange. :)
Some more substantial observations: 1. Shouldn’t the copyright year at the top be 2018? 2. The literal popen() call down in the handler for email-send-method == “pipe” might be insufficient for some situations. Some people like to use mailx as the command line interface to the system MTA, because on many systems it’s already configured to feed it, reducing the setup burden. Unlike sendmail(1), it doesn’t take RFC 822 headers on stdin, it can only set the Subject and the From headers via command line parameters: http://pubs.opengroup.org/onlinepubs/009695399/utilities/mailx.html Another common command line mailer used for this purpose is msmtp, which unlike mailx, *demands* that the subject header be given in RFC 822 form: https://marlam.de/msmtp/ Two options: a. Just say that mailx isn’t allowed, because it doesn’t have the correct interface. b. Add a printf-like syntax for building the command with a sensible set of substitutions: ‘mailx -s "%s"' _______________________________________________ fossil-dev mailing list fossil-dev@mailinglists.sqlite.org http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/fossil-dev