On Wed, Jan 16, 2013 at 5:48 PM, j. van den hoff
<[email protected]>wrote:

> is this a bug or a feature? I do hope the former since it's really bad
> behaviour when driving `fossil' with a script.
>

It's an "as designed bug." The argument handling is based on the argument
count, and an empty argument is counted (the shell gives us an empty string
in that case).

We could arguably tweak the base args parsing (which happens at a much
earlier stage) to ignore empty tokens, but i'm not sure that's a good idea.
e.g. it would prohibit (commit -m '') and would cause very unwanted
side-effects with (commit -m '' foo.bar).

Alternately, we could improve the handling for this specific command, but
be aware that this is only one of many commands which are likely affected
by similar corner cases.

The relevant code is here:

http://fossil-scm.org/index.html/artifact/2560da3ea2ed20a85769cd44f1c83f672b2db2c0?ln=1587-1614



-- 
----- stephan beal
http://wanderinghorse.net/home/stephan/
http://gplus.to/sgbeal
_______________________________________________
fossil-users mailing list
[email protected]
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Reply via email to