Am Mittwoch, 23. Januar 2013, 10:54:12 schrieb Stephan Beal: > On Wed, Jan 23, 2013 at 10:15 AM, Stephan Beal <[email protected]>wrote: > > i'll try to get this snuck in during work today, but we've got a half-day > > team meeting, so it might have to wait until tomorrow. In any case, i've > > set a reminder event so i won't forget it. > > Hi, Rudi, > > a small problem: > > +FOSSIL_ENABLE_JSON = 1 > > > i can't hard-code that into the makefile (same for FOSSIL_ENABLE_MARKDOWN) > because the JSON/markdown support is optional and neither one is on by > default.
Hi Stephan, I didn't know that this is the default. Just put the definition of FOSSIL_ENABLE_JSON in a comment. That is the way it was done for the mingw part. > > Does nmake support the equvalent of: > > foo ?= N > > meaning "if foo is defined then use it, else set it to N"? If so i could > use that here. I do not know nmake enough to tell if it supports this. > > And to clarify: > > +!ifdef FOSSIL_ENABLE_JSON > +TCC = $(TCC) -DFOSSIL_ENABLE_JSON > +RCC = $(RCC) -DFOSSIL_ENABLE_JSON > +!endif > > shouldn't that be: > > !if FOSSIL_ENABLE_JSON > ... > !endif > > :-? > > ifdef will trigger even if the enable flag is set to 0. Correct. But I would comment the FOSSIL_ENABLE_JSON just like it was done for the mingw part. So to enable it you remove the comment. Rüdiger _______________________________________________ fossil-users mailing list [email protected] http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
