First of all, Bruno, thanks for all your work on the spec!
Now, for my suggestions:1) I can see where you are going with all the post scripts in order to automate the entire installation, but I think most all of this is very bad practice and should be moved into a README.rpm or INSTALL.redhat or similar file which walks the user through the steps/config changes needed. Especially things like restarting postgres I think should never be done automatically. 2) I'm not quite done tweaking the requires/buildrequires, but I added buildreqs for chkconfig and service which are used in the post and pre/ postun scripts. 3) I also stuck a '|| :' after the service calls in order to catch any errors
4) I added checks to the post/preun/postun scripts for the following:- in post, only chkconfig --add fossology if this is the initial install (not an upgrade) - in preun, only stop fossology and remove from chkconfig if this is an erase (not part of an upgrade) - in postun, run a conditional restart of the fossology service if this is an upgrade 5) I also added some "TODO" comments about stuff I believe should be a part of the spec file instead of calling external scripts for postinstall or cleanold. For example, rely on RPM itself to clean up the files, and do stuff like 'userdel' from the spec file directly.
Sorry I've put this off so long...I see Dan just sent an email regarding some of the other RPM packaging issues as far as versions/repositories, etc. so I'll follow-up on those points in the other thread.
-Jeff
fossology.spec
Description: Binary data
_______________________________________________ fossology mailing list [email protected] http://fossology.org/mailman/listinfo/fossology
