Matt Taggart wrote: >> Revision: 2078 >> http://fossology.svn.sourceforge.net/fossology/?rev=2078&view=rev >> Author: rrando >> Date: 2009-04-30 23:38:04 +0000 (Thu, 30 Apr 2009) >> >> Log Message: >> ----------- >> Changed a Warning to a NOTE: as it seemed to be more of an informational note >> rather than a warning about something possibly wrong. >> > > It is something possibly wrong. > > I did this in a bunch of places (sometimes in loops too): > > common/Makefile: echo "WARNING: $(DESTDIR)$(CONFPATH)/$$file already > exists."; \ > common/Makefile: echo "WARNING: $(DESTDIR)$(CONFPATH)/Db.conf already > exists."; \ > db/Makefile: echo "WARNING: $(DESTDIR)/etc/cron.d/fossology already > exists."; \ > scheduler/Makefile: echo "WARNING: $(DESTDIR)$(SYSCONFDIR)/$(DEFFILE) > already exists."; \ > scheduler/Makefile: echo "WARNING: $(DESTDIR)$(INITDIR)/$(INITFILE) already > exists."; \ > > I used "WARNING" because if the user is seeing this message it's because > they are installing over the top of an old install. That means that their > config files are possibly out of date and they'd should definitely review > them to make sure. > > For example say a user is moving from one release to a newer one, and some > new agents are added. Their Scheduler.conf file won't list the new agents > and their new install won't function properly. So I want to make sure they > know about it. I bet there are ANSI escape sequences for blinking text, > maybe I should use that :) > > Also, if the user sets the OVERWRITE variable before doing "make install" > or the "--overwrite" flag to fo-postinstall, then they will get fresh > versions of the config files. > > Opinions? > > Well, this is one of those items where it's not clear what the 'correct' answer is. Bob and I both felt that Warning was too strong. Nothing is 'wrong' it's just that a file exists that could possibly be updated. For some products, debian will go into a mode where you can use your copy, replace, diff or edit. I think ideally, that is what should happen on debian, for RH based releases, I'm not sure what they do. I just ran into a situation where phppgadmin MADE me update it's conf file to the dist one. I felt that was too strong a nudge. I still like NOTE: for this particular situation.
As for the case of specifying --overwrite or changing the makefile, I don't see this as an issue, they want new copies of those files. I don't see the point as to how Warnings relate to this particular case. -- Mark Donohoe MOST/OSTT, Cupertino CA. fossology.org _______________________________________________ fossology mailing list [email protected] http://fossology.org/mailman/listinfo/fossology
