On Jul 16, 2009, at 9:58 PM, Ma, Dong (vinc...@gdcc-bj-most) wrote:

Hi Bob,

See my comments inline.

-----Original Message-----
From: Gobeille, Robert
Sent: Friday, July 17, 2009 5:37 AM
To: Ma, Dong (vinc...@gdcc-bj-most)
Cc: Liang, Ricky (TSG-GDCC-BJ-MOST); oslo.tools-team
Subject: rpms

Hi Vincent,

I need you to rebuild the rpm's with a couple of small changes:

1) Release:      .centos5

I'm not sure how you were planning on incrementing the release, but
why don't we put the increment before the distro.  So this should be:

Release:   .1centos5

I am not sure why you consider put the increment before the distro like .1centos5, if our fossology team have this naming guidelines before, if we have I'll follow the naming guidelines and rebuild the packages.

We do not have guidelines. You are creating our first rpm based packages. So what you do will set the precedent. This is why I'm trying to be so careful.


But as I know about fedoraproject naming guidelines, they add the release number like this 1.centos5(1 --> release number and .centos5 ---> DistTag), incrementing the release will like 2.centos5. I have added these in the rpms I have created. I recommend we follow the fedoraproject naming guidelines, you can see it here: http://fedoraproject.org/wiki/Packaging:NamingGuidelines
What's your thought?

Good idea but we have to keep in mind that we build for multiple distros. Fedora doesn't have to be concerned about that.

Besides, as you mentioned we didn't need to provide separate packages for RHEL and CentOS, I plan to combine the RHEL and CentOS rpm packages as one, and follow the fedoraproject DistTag naming guidelines call it
        .el5  == (centos5 rhel5)
        .el4  == (centos4 rhel4)
So for example the rpm package name will be 'fossology-1.1.0-1.el5.x86_64.rpm':
        fossology ---> Name
        1.1.0     ---> Version
        1         ---> Release
        .el5      ---> Dist
        x86_64    ---> Arch
And our YUM repository directory change to
        /rpms/epel/4       (for centos4)
        /rpms/epel/5       (for centos5)
/rpms/epel/5Server /rpms/epel/5Client link to /rpms/epel/ 5 (for rhel5) /rpms/epel/4AS /rpms/epel/4ES /rpms/epel/4WS link to /rpms/epel/ 4 (for rhel4)

So we can use one fossology.repo file for both RHEL and CentOS.
-----------   file:  fossology.repo ---------

# FOSSology releases
[fossology]
name=Fossology releases
baseurl=http://fossology.org/rpms/epel/$releasever/$basearch
enabled=1
gpgcheck=0

# FOSSology release candidates and other special builds
[fossology-testing]
name=Fossology testing
baseurl=http://fossology.org/rpms-testing/epel/$releasever/$basearch
enabled=0
gpgcheck=0

-----------   file:  fossology.repo ---------

And the rpm to install fossology.repo will name as fossology- repo-1.rpm (as you commented).

What about your opinion? If you confirmed these, I'll rebuild the packages, change the YUM repository and upload new to sourceforge.

These look great.


2) The %description is wrong.
Could you make it "An open and modular architecture for analyzing
software.  Currently specializing on license detection."


Ok, I'll change it.

I assume you will get the French translation from Bruno.

Great job Vincent.

Bob Gobeille
_______________________________________________
fossology mailing list
[email protected]
http://fossology.org/mailman/listinfo/fossology

Reply via email to