Jonas Maebe wrote:

On 12 Apr 2008, at 20:53, Michael Van Canneyt wrote:

I hope to have fixed what seems to be the last open bug in the
streaming system. Unless there are additional reports, the whole
cleanroom implementation will be merged to fixes 2.2 and the release
process for 2.2.2 will (finally) be started.

As mentioned by Florian elsewhere, this commit seems to have broken 6 tests in the testsuite last night.


lazarus has problems with a form structure like:

TLogForm = class(TSettingsForm)

TSettingsForm = class(TForm)

where TLogForm has resources but TSettingsForm does not. I think at least part of this is a problem with lazarus that I am investigating, but I have found a crash in the writer because of a missing empty list check - see attached patch
diff -uNr --exclude=.svn --exclude='*.rst' trunk/fpcsrc/rtl/objpas/classes/writer.inc trunk.w/fpcsrc/rtl/objpas/classes/writer.inc
--- trunk/fpcsrc/rtl/objpas/classes/writer.inc	2008-04-12 20:11:31.000000000 +0100
+++ trunk.w/fpcsrc/rtl/objpas/classes/writer.inc	2008-04-13 12:26:26.000000000 +0100
@@ -608,8 +608,9 @@
     try
       Component.GetChildren(@WriteComponent, FRoot);
     Finally
-      For I:=0 to FAncestors.Count-1 do 
-        FAncestors.Objects[i].Free;
+      if Assigned(FAncestors) then
+        For I:=0 to FAncestors.Count-1 do
+          FAncestors.Objects[i].Free;
       FreeAndNil(FAncestors);
     end;    
   finally
_______________________________________________
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
http://lists.freepascal.org/mailman/listinfo/fpc-devel

Reply via email to