Am 10.10.2010 06:56, schrieb Hans-Peter Diettrich: > Florian Klämpfl schrieb: >> Am 10.10.2010 00:32, schrieb Hans-Peter Diettrich: >>> Florian Klämpfl schrieb: >>> >>>>> Now I hope that this patch will be applied to the trunk soon. >>>> No. It's a mess and I won't sort it out. >>> What do you feel a need for sorting out? >> >> Splitting the patch in understandable parts which can be committed >> separately with appropriate commit messages, > > I.e. one patch for every single moved variable???
If needed, yes. If one variable is moved and it involves more files, it needs a separate commit. It makes also things like bisecting bugs easier. > >> fix formatting, remove >> unneeded parts, remove stuff to be discussed first, see below. > >> >> It is good practive to patch and commit sources in well defined, >> traceble steps and this is not possible with this patch. > > Some separatable patches have been presented already. I merged them into > the big patch, to simplify merging with trunk. Did you ever work for a longer time in a team with a vcs? > Feel free to apply these > patches first... This another part of the mess. > > >>>> comments I made about the older patch are ignored, >>> Which in detail do you mean? >> >> The aasmbase change, see my comment in your issue report. > > Question: do you have a better solution for the ppudump dependencies? There is nothing wrong with using aasmbase in ppudump. _______________________________________________ fpc-devel maillist - fpc-devel@lists.freepascal.org http://lists.freepascal.org/mailman/listinfo/fpc-devel