On 20/05/15 20:52, Edmund Grimley Evans wrote:
> There are not a lot of changes here: mostly just filling in a few gaps
> that were helpfully left for me to fill in. The most interesting
> change is in t_linux.pas, where I had to do something a bit different
> with linker scripts and "-T". There's a comment in the code there.

I have a small question about that change:

> +{$ifdef AArch64}
> +{$define LINKERSCRIPT_INCLUDED}
> +      if isdll or (sysrootpath='') then begin

Why do you always do this when creating a library?

Also a stylistic note: in the compiler we generally put "begin" and
"end" on their own line, indented by two spaces compared to the outer
lexical block.

I've committed your fpcmake/fpmkunit patches and regenerated the Makefiles.


Jonas
_______________________________________________
fpc-devel maillist  -  [email protected]
http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel

Reply via email to