On Fri, 10 Jan 2025, Marģers . via fpc-devel wrote:

I have been working on fixing up Textmode IDE and some related packages
(Free Vision, rtl-console) One of the recent large improvement is
scrolling by mouse.  I am happy how it turned out.

I tested the changes, works really well :-)

  Currently mouse scroll
events are going under evMouseDown.  But it does have some unwanted side
effects in existing code.  Mouse click triggered by scrolling.  For FV and
IDE I have fixed most of them.  Maybe to add new mouse event type just for
scrolling events (evMouseWheel as it is done in
https://github.com/magiblot/tvision )?

I think this new mouse event type is a good idea.

It would go a long way to support
existing code base.  Even thou mouse scrolling was introduced in 3.2.0 but
limited only for Unix/Linux systems and its usage might be minimal.  More
or less I am looking for an approval and necessary changes I am ready to
implement.  In this context the true question is: am I allowed to look
around and get inspiration (or copy) of other open source projects? Earlier mentioned Turbo Vision (in C++) project has MIT license and a lot
of great ideas implemented.  Do I go as far and make identical variable
and function naming and use the same implementation details?  Direct
translation is not possible and I am not looking for that.

I would implement as you see fit, but add a reference in the header:

{
  Feature XYZ inspired by implementation in 
https://github.com/magiblot/tvision/XYZ
}

This way you give due credit to the original author.

Michael.

_______________________________________________
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel

Reply via email to