> Am 18.04.2025 um 14:07 schrieb Michael Van Canneyt via fpc-devel > <fpc-devel@lists.freepascal.org>: > > > > On Fri, 18 Apr 2025, Florian Klämpfl via fpc-devel wrote: > >> >> >>> Am 16.04.2025 um 12:00 schrieb Michael Van Canneyt via fpc-devel >>> <fpc-devel@lists.freepascal.org>: >>> On Wed, 16 Apr 2025, Florian Klämpfl via fpc-devel wrote: >>>> On 15.04.25 22:52, runewalsh via fpc-devel wrote: >>>>> What’s the position on MR !694? Person with the yellow avatar mentioned >>>>> in https://gitlab.com/freepascal.org/fpc/source/-/ >>>>> commit/922457e5b58d76a13ff706f9220d9d6350631930#note_2390656703 there was >>>>> some discussion somewhere, and that’s all. >>>> Our main issue is that nobody really feels capable of reviewing it :( The >>>> initial contributors of the heap manager are basically gone and nobody >>>> else is really that deep into this code to do a review. >>> Since Runewalsh is deep in it, clearly we're not off worse if we change it >>> :-) >>> So, in order to progress: we'll throw it in the wild to be field-tested. >>> So I propose the following: I will add the new heap manager in a new file. >> >> Please do it in a way which preserves line history: copy heap.inc to >> oldheap.inc, add and commit it. Then accept the merge request. Add ifdefs. >> So heap.inc keeps line history making debugging in the future easier. > > I intended to do it more or less so, yes. >
The way you did it, line history is broken :(
_______________________________________________ fpc-devel maillist - fpc-devel@lists.freepascal.org https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel
