On Apr 24, 2006, at 5:47 AM, John Kristoff wrote:

> On Mon, 24 Apr 2006 02:51:41 +0200
> Roy Arends <[EMAIL PROTECTED]> wrote:
>
>> What version of fpdns and Net::DNS are you using ?
>
> Here is what I have and what I see:
>
>   $ perl -e 'use ExtUtils::Installed; $installed=ExtU::Installed- 
> >new();  print $installed->version("Net::DNS"),"\n";'
>   0.57
>
>   $ fpdns -v
>   fpdns version 0.9.3
>
>   $ perl -we 'use Net::DNS; use Net::DNS::Fingerprint; my  
> $engine=Net::DNS::Fingerprint->new(qchaos=>1); print $engine->string 
> ("62.181.128.1", 53), "\n";'
>   Use of uninitialized value in substitution (s///) at /System/ 
> Library/Perl/5.8.6/Text/ParseWords.pm line 16.
>   Use of uninitialized value in length at /System/Library/Perl/ 
> 5.8.6/Text/ParseWords.pm line 29.
>   ISC BIND 8.2.2-P3 -- 8.3.0-T2A [recursion enabled]  id: ""
>
> Note, the use of -w (warnings) is what produces the problem.
> Otherwise, there are no complaints.  Just to verify, I added
> warnings to fpdns and it too will complain to me if enabled.

Ah, yes, I see it now. Thanks. (-w was what I was missing).

Here is the patch for Net::DNS::RR::TXT that'll fix the problem. I'll  
send Olaf.

Just to be complete, it is not legal (protocolwise) to have an rdlen  
of 0 wrt TXT records. However, code should not barf on it.

Thanks,

Roy


--- TXT.pm      2006-04-24 08:50:56.000000000 +0200
+++ TXT.pm      2006-04-24 08:51:37.000000000 +0200
@@ -64,7 +64,7 @@
sub _build_char_str_list {
         my ($self, $rdata_string) = @_;

-       my @words = shellwords($rdata_string);
+       my @words = shellwords($rdata_string) if $rdatastring;

         $self->{'char_str_list'} = [];




_______________________________________________
fpdns mailing list
[email protected]
https://www.rfc.se/mailman/listinfo/fpdns

Reply via email to