On 25 June 2014 16:38:11 Martin Hejnfelt wrote:
> On Wed, 2014-06-25 at 09:06 +0300, Timo Teras wrote:
> > It did. Thanks. Forget the earlier patch, it's irrelevant and the
> > original code is right. Seems the bug is in the generic code and
> > affects all drivers that are capable of 'finger present' detection.
> >
> > It seems to be a bug since 2008 but mostly unnoticed due to doing only
> > that one enrollment.
> >
> > The following should fix it:
> >
> > diff --git a/libfprint/imgdev.c b/libfprint/imgdev.c
> > index f960ee3..3b5d3f3 100644
> > --- a/libfprint/imgdev.c
> > +++ b/libfprint/imgdev.c
> > @@ -159,7 +159,7 @@ void fpi_imgdev_report_finger_status(struct fp_img_dev
> > *imgdev,>
> > r > 0 && r != FP_ENROLL_COMPLETE && r !=
> > FP_ENROLL_FAIL) {
> >
> > imgdev->action_result = 0;
> > imgdev->action_state =
> > IMG_ACQUIRE_STATE_AWAIT_FINGER_ON;
> >
> > - dev_change_state(imgdev,
> > IMG_ACQUIRE_STATE_AWAIT_FINGER_ON); +
> > dev_change_state(imgdev, IMGDEV_STATE_AWAIT_FINGER_ON);>
> > }
> > break;
> >
> > case IMG_ACTION_VERIFY:Hi Martin, > This fixes it perfectly! I can vouch for this change, at least it works > both with my U.are.u 4500 (using uru4000) and my upek touchstrip (using > upekts_img) readers... Thanks a lot! One off-topic question: I got earlier reports that upekts_img doesn't work reliably on some devices. Does it work well for you? Regards, Vasily > > Kind regards, > Martin Hejnfelt
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ fprint mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/fprint
