Davidlohr Bueso wrote:
> I'm sending a patch that allows fprint to obtain the image quality and 
> confidence numbers. Works has follows:
> 
> int quality_score;
> float confidence;
> struct fp_img img;
> 
> /* do things and fill the fp_img structure */
> 
> fp_img_get_quality(img, &score, &confidence);
> 
> I think this feature is quite necessary for the project, hope it can be 
> used.

Please send the patch as plaintext so that it can be email-reviewed and 
so that I can just hand off the email to git if I like the patch...

Please add 2 separate functions. That way it is easier to bind the API 
to languages that do not have the concept of pass-by-address.

Also please ensure API documentation is there if you haven't included 
some already.

> PS: Tried it out with fprint_demo and worked like a charm (should I send 
> that patch, so we can incorporate it to that project?)

It's worth sending it anyway, then I'll consider it :)

Thanks,
Daniel
_______________________________________________
fprint mailing list
[email protected]
http://lists.reactivated.net/mailman/listinfo/fprint

Reply via email to