Pavel Herrmann wrote:
> Sorry for the last patch, I did too much cleaning before diffing and
> there is one error in libfprint/Makefile.am (OTHER_SRC is missing)
>
> anyway, now there is a hopefully correct one, with drivers implemented
> in a single parameter (--with-drivers=) to configure as Bastien suggested.
This looks great, thanks!
Some comments:
I know I designed how it is at the moment, but I think we should change
how imagemagick is called. Instead of supporting imgdev->enlarge_factor,
aes4000 should just call im_resize() directly, and claim that the
returned images are sized appropriately. im_resize and supporting code
can then be moved into it's own file, similar to how aeslib is. This
allows us to separate the resizing hack from the non-hacky code, and
also gets rid of REQUIRE_IMAGEMAGICK ifdefs.
Also, you can avoid having to do cflags modifications like this one:
libfprint_la_CFLAGS += -DENABLE_URU4000
by using AC_DEFINE in configure.ac to place an entry in config.h
Thanks!
Daniel
_______________________________________________
fprint mailing list
[email protected]
http://lists.reactivated.net/mailman/listinfo/fprint
