-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hey everyone,

I've attached a patch to handle a nil interface when running modules with
Exploit::Capture.

Unlike Exploit::Lorcon, this module doesn't require an interface name to be
given since it can get it from pcap.  However, it was using the possibly nil
interface in the ifconfig call.  In an auxiliary module I'm messing with, I
would get this unless I specified an interface in the script or through the
options:

[-] Auxiliary failed: can't convert nil into String

So I moved the ifconfig to after the pcap lookupdev call and it uses that 
instead.

Thanks,
Kris Katterjohn

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iQIVAwUBSOebAf9K37xXYl36AQIdJg//bYCGhCU8fKfEQeRgInCKpav96Cl1cleF
qhOqoKNjbvZmwfdavQzGY7q6rVCk9o4a6MFTxjEAV2hTUQoN8XlZWv0Bh3As7bUT
Gz57PWM9dN/qJjxTVOIunt9VYYijs4bgjFyTDFPji954uc9Xao0zpDmwWa93BhA3
ex/QUhCADH7ju6C3uKKYSYU9lUTyP1+bulH1JnYOeBMdo/bos2MOAYhmgM6iw3qL
rgttRRz701NKacg/MsYfNhxdxn5Px0mnEJF5i41H84DVxfLnc89ob/oH7mKcwLZF
CBUYFGZWyN9y+5P48Pj3AHKOR+tUMCcMguYQnxlHWwlNUP0/axPlLWCqFO0SbR4I
oc24aR7zRDdR/GkVZUdKa8JBbsjLLOUfOUz0ftbZzsY1esPztksCWbqNpVtjUj8E
pla7gq58YHhdFLXfD8m8FPHG/9Lm3vWAx1BpQD/sbwElHHIS85HI1CNVguGUHrn2
zn45iVHevcDx6vQWpNAuem4OPDKNZnjrERZahq7zIAsbJWvN6KkrX5ZkAqcWbYXq
zokPMk600r7oRP4MNvfB5XnH9mHBQl+ikWcrj5Zwbynqiv9Q1oP9y0onXzA9eZQv
kuqxbJz50cNtzcM69gKoTiP+hwEvzXwMiI4QYXbfMOxfHvEEBMyKo7RnAm9qS3hX
D0JjGCIZLrs=
=OovN
-----END PGP SIGNATURE-----
Index: lib/msf/core/exploit/capture.rb
===================================================================
--- lib/msf/core/exploit/capture.rb	(revision 5711)
+++ lib/msf/core/exploit/capture.rb	(working copy)
@@ -70,15 +70,15 @@
 			raise RuntimeError, "Pcaprub not available"
 		end
 		
-		# XXX: Force the interface to be up
-		system("ifconfig", datastore['INTERFACE'], "up")
-	
 		# Capture device
 		dev = datastore['INTERFACE'] || ::Pcap.lookupdev
 		len = (datastore['SNAPLEN']  || 65535).to_i
 		tim = (datastore['TIMEOUT']  || 0).to_i
 		fil = datastore['FILTER']
 				
+		# XXX: Force the interface to be up
+		system("ifconfig", dev, "up")
+
 		self.capture = ::Pcap.open_live(dev, len, true, tim)
 
 		if (not self.capture)
_______________________________________________
Framework-Hackers mailing list
Framework-Hackers@spool.metasploit.com
http://spool.metasploit.com/mailman/listinfo/framework-hackers

Reply via email to