On Sat, Jan 17, 2009 at 02:37, Ethan Jucovy <ethan.juc...@gmail.com> wrote:
> I've implemented PLIP #247, Automate ZCML Loading for Plone Plugins
> (http://plone.org/products/plone/roadmap/247) and committed a review
> buildout here:
>  https://svn.plone.org/svn/plone/review/plip247-automate-plugin-zcml
> for your review.

I have started my review.

To my dismay, however, the z3c.autoinclude package has several test
failures. I understand that this package is also being used by the
Grok project, and it appears to work as advertised, but test failures
is not a good sign of package quality. For example, utils.txt somehow
triggers an assert on line 99 in utils.py, which has a somewhat
distressing comment:

   assert len(non_namespaced_dists) == 1          ### we really are in
trouble if we get into a situation with more than one

Could you comment on the state of these failures?

> The buildout is branched from the 3.3 review bundle
> buildout based on buildout.eggtractor, which automatically generates ZCML
> slugs for development packages and puts them in parts/instance/etc/package-
> includes.  Since the purpose of PLIP 247 is to automate ZCML loading, those
> automatically generated ZCML slugs should be removed.  I've hardly ever used
> buildout so I'm not sure how to change that behavior -- sorry about that;
> I'll change it if I can figure out how.

Simply *not* use buildout.eggtractor; you only have 3 eggs in this
buildout, add them to the develop, eggs and zcml lines and Bob's your
uncle. Alternatively, just set tractor-autoload-zcml to false, which
you did.

Martijn Pieters

Framework-Team mailing list

Reply via email to